From: Paolo Abeni <pabeni@redhat.com>
To: Simon Horman <horms@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: Breno Leitao <leitao@debian.org>,
Chas Williams <3chas3@gmail.com>,
Guo-Fu Tseng <cooldavid@cooldavid.org>,
Moon Yeounsu <yyyynoom@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH net v2 3/5] MAINTAINERS: Add limited globs for Networking headers
Date: Thu, 22 Aug 2024 15:37:06 +0200 [thread overview]
Message-ID: <5ecac29d-251a-4db8-abf4-e73c4e1eca55@redhat.com> (raw)
In-Reply-To: <20240821-net-mnt-v2-3-59a5af38e69d@kernel.org>
On 8/21/24 10:46, Simon Horman wrote:
> This aims to add limited globs to improve the coverage of header files
> in the NETWORKING DRIVERS and NETWORKING [GENERAL] sections.
>
> It is done so in a minimal way to exclude overlap with other sections.
> And so as not to require "X" entries to exclude files otherwise
> matched by these new globs.
>
> While imperfect, due to it's limited nature, this does extend coverage
> of header files by these sections. And aims to automatically cover
> new files that seem very likely belong to these sections.
>
> The include/linux/netdev* glob (both sections)
> + Subsumes the entries for:
> - include/linux/netdevice.h
> + Extends the sections to cover
> - include/linux/netdevice_xmit.h
> - include/linux/netdev_features.h
>
> The include/uapi/linux/netdev* globs: (both sections)
> + Subsumes the entries for:
> - include/linux/netdevice.h
> + Extends the sections to cover
> - include/linux/netdev.h
>
> The include/linux/skbuff* glob (NETWORKING [GENERAL] section only):
> + Subsumes the entry for:
> - include/linux/skbuff.h
> + Extends the section to cover
> - include/linux/skbuff_ref.h
>
> A include/uapi/linux/net_* glob was not added to the NETWORKING [GENERAL]
> section. Although it would subsume the entry for
> include/uapi/linux/net_namespace.h, which is fine, it would also extend
> coverage to:
> - include/uapi/linux/net_dropmon.h, which belongs to the
> NETWORK DROP MONITOR section
> - include/uapi/linux/net_tstamp.h which, as per an earlier patch in this
> series, belongs to the SOCKET TIMESTAMPING section
I think both the above files should belong also to the generic
networking section. If there is agreement, I think can be adjusted with
an incremental patch, instead of re-spinning the whole series - that I'm
applying now.
Thanks,
Paolo
next prev parent reply other threads:[~2024-08-22 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 8:46 [PATCH net v2 0/5] MAINTAINERS: Networking updates Simon Horman
2024-08-21 8:46 ` [PATCH net v2 1/5] MAINTAINERS: Add sonet.h to ATM section of MAINTAINERS Simon Horman
2024-08-21 8:46 ` [PATCH net v2 2/5] MAINTAINERS: Add net_tstamp.h to SOCKET TIMESTAMPING section Simon Horman
2024-08-21 14:02 ` Willem de Bruijn
2024-08-21 8:46 ` [PATCH net v2 3/5] MAINTAINERS: Add limited globs for Networking headers Simon Horman
2024-08-22 13:37 ` Paolo Abeni [this message]
2024-08-22 19:12 ` Simon Horman
2024-08-21 8:46 ` [PATCH net v2 4/5] MAINTAINERS: Add header files to NETWORKING sections Simon Horman
2024-08-21 8:46 ` [PATCH net v2 5/5] MAINTAINERS: Mark JME Network Driver as Odd Fixes Simon Horman
2024-08-22 14:00 ` [PATCH net v2 0/5] MAINTAINERS: Networking updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ecac29d-251a-4db8-abf4-e73c4e1eca55@redhat.com \
--to=pabeni@redhat.com \
--cc=3chas3@gmail.com \
--cc=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).