From: Dan Carpenter <dan.carpenter@linaro.org>
To: Simon Horman <horms@kernel.org>
Cc: Roger Quadros <rogerq@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Julien Panis <jpanis@baylibre.com>,
Chintan Vankar <c-vankar@ti.com>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code
Date: Thu, 26 Sep 2024 23:14:07 +0300 [thread overview]
Message-ID: <5ed2cd4e-cb50-4a21-93e2-8ba8d627f20a@stanley.mountain> (raw)
In-Reply-To: <20240926155139.GG4029621@kernel.org>
On Thu, Sep 26, 2024 at 04:51:39PM +0100, Simon Horman wrote:
> On Thu, Sep 26, 2024 at 12:50:45PM +0300, Dan Carpenter wrote:
> > This error handling has a typo. It should i++ instead of i--. In the
> > original code the error handling will loop until it crashes.
> >
> > Fixes: da70d184a8c3 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> Hi Dan,
>
> Unfortunately this patch didn't apply cleanly to net
> which throws our CI off. So, unfortunately, I think it needs to
> be rebased and reposted (after the 24h grace period).
It's not a matter of rebasing... I guess I accidentally deleted a space
character at the start of the first line of the diff? Weird.
Anyway, I'll resend.
regards,
dan carpenter
prev parent reply other threads:[~2024-09-26 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 9:50 [PATCH net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code Dan Carpenter
2024-09-26 10:23 ` Sverdlin, Alexander
2024-09-26 12:25 ` Roger Quadros
2024-09-26 15:51 ` Simon Horman
2024-09-26 20:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ed2cd4e-cb50-4a21-93e2-8ba8d627f20a@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexander.sverdlin@siemens.com \
--cc=c-vankar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=horms@kernel.org \
--cc=jpanis@baylibre.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox