From: Yonghong Song <yhs@fb.com>
To: Hou Tao <houtao1@huawei.com>, Alexei Starovoitov <ast@kernel.org>
Cc: Martin KaFai Lau <kafai@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
<netdev@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v5] selftests/bpf: do not export subtest as standalone test
Date: Tue, 8 Feb 2022 07:57:32 -0800 [thread overview]
Message-ID: <5f455130-f73e-bf2a-ed54-e81b75585a21@fb.com> (raw)
In-Reply-To: <20220208065444.648778-1-houtao1@huawei.com>
On 2/7/22 10:54 PM, Hou Tao wrote:
> Two subtests in ksyms_module.c are not qualified as static, so these
> subtests are exported as standalone tests in tests.h and lead to
> confusion for the output of "./test_progs -t ksyms_module".
>
> By using the following command:
>
> grep "^void \(serial_\)\?test_[a-zA-Z0-9_]\+(\(void\)\?)" \
> tools/testing/selftests/bpf/prog_tests/*.c | \
> awk -F : '{print $1}' | sort | uniq -c | awk '$1 != 1'
>
> find out that other tests also have the similar problem, so fix
> these tests by marking subtests in these tests as static.
>
> Signed-off-by: Hou Tao <houtao1@huawei.com>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2022-02-08 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 6:54 [PATCH bpf-next v5] selftests/bpf: do not export subtest as standalone test Hou Tao
2022-02-08 15:57 ` Yonghong Song [this message]
2022-02-08 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f455130-f73e-bf2a-ed54-e81b75585a21@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=houtao1@huawei.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).