From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register. Date: Fri, 15 Sep 2017 09:49:41 +0200 Message-ID: <5f4bd003-d251-5a14-497a-9cc72dd0f160@xilinx.com> References: <1505373391-18697-1-git-send-email-fahad.kunnathadi@dexceldesigns.com> <20170914143454.GB27601@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: , , , , , To: Andrew Lunn , Fahad Kunnathadi Return-path: In-Reply-To: <20170914143454.GB27601@lunn.ch> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 14.9.2017 16:34, Andrew Lunn wrote: > On Thu, Sep 14, 2017 at 12:46:31PM +0530, Fahad Kunnathadi wrote: >> To clear Speed Selection in MDIO control register(0x10), >> ie, clear bits 6 and 13 to zero while keeping other bits same. >> Before AND operation,The Mask value has to be perform with bitwise NOT >> operation (ie, ~ operator) >> >> This patch clears current speed selection before writing the >> new speed settings to gmii2rgmii converter > > Hi Fahad > > I expect you will find other issues with this driver. I pointed some > out at the time it is submitted, but the developers went quiet as soon > as it was accepted. Can you please point me to that email? I will create ticket about it in our system to get them resolved. Thanks, Michal