From: David Ahern <dsahern@kernel.org>
To: Sabrina Dubroca <sd@queasysnail.net>, netdev@vger.kernel.org
Cc: Kuniyuki Iwashima <kuniyu@google.com>
Subject: Re: [PATCH net 1/2] neighbour: restore protocol != 0 check in pneigh update
Date: Tue, 10 Mar 2026 17:16:29 -0600 [thread overview]
Message-ID: <5f8d37f7-a395-4143-8580-56f7d6f77656@kernel.org> (raw)
In-Reply-To: <38c61de1bb032871a886aff9b9b52fe1cdd4cada.1772894876.git.sd@queasysnail.net>
On 3/10/26 3:59 PM, Sabrina Dubroca wrote:
> Prior to commit dc2a27e524ac ("neighbour: Update pneigh_entry in
> pneigh_create()."), a pneigh's protocol was updated only when the
> value of the NDA_PROTOCOL attribute was non-0. While moving the code,
> that check was removed. This is a small change of user-visible
> behavior, and inconsistent with the (non-proxy) neighbour behavior.
>
> Fixes: dc2a27e524ac ("neighbour: Update pneigh_entry in pneigh_create().")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> ---
> net/core/neighbour.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
good find. Thanks, Sabrina
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2026-03-10 23:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 21:59 [PATCH net 0/2] neighbour: fix update of proxy neighbour Sabrina Dubroca
2026-03-10 21:59 ` [PATCH net 1/2] neighbour: restore protocol != 0 check in pneigh update Sabrina Dubroca
2026-03-10 23:16 ` David Ahern [this message]
2026-03-11 4:04 ` Kuniyuki Iwashima
2026-03-10 21:59 ` [PATCH net 2/2] selftests: rtnetlink: add neighbour update test Sabrina Dubroca
2026-03-11 4:10 ` Kuniyuki Iwashima
2026-03-12 2:10 ` [PATCH net 0/2] neighbour: fix update of proxy neighbour patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f8d37f7-a395-4143-8580-56f7d6f77656@kernel.org \
--to=dsahern@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox