netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, "David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [patch V2 1/4] net: dst: Prevent false sharing vs. dst_entry::__refcnt
Date: Wed, 15 Mar 2023 16:26:47 -0600	[thread overview]
Message-ID: <5f97f6d5-d979-d501-a090-b5a69f33fa45@gmail.com> (raw)
In-Reply-To: <20230315133659.4d608eb0@kernel.org>

On 3/15/23 2:36 PM, Jakub Kicinski wrote:
> On Tue,  7 Mar 2023 13:57:42 +0100 (CET) Thomas Gleixner wrote:
>> Move the rt[6i]_uncached[_list] members out of struct rtable and struct
>> rt6_info into struct dst_entry to provide padding and move the lwtstate
>> member after that so it ends up in the same cache line.
> 
> Eric, David, looks reasonable? 

Reviewed-by: David Ahern <dsahern@kernel.org>


  parent reply	other threads:[~2023-03-15 22:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 12:57 [patch V2 0/4] net, refcount: Address dst_entry reference count scalability issues Thomas Gleixner
2023-03-07 12:57 ` [patch V2 1/4] net: dst: Prevent false sharing vs. dst_entry::__refcnt Thomas Gleixner
2023-03-15 20:36   ` Jakub Kicinski
2023-03-15 20:47     ` Eric Dumazet
2023-03-15 22:26     ` David Ahern [this message]
2023-03-07 12:57 ` [patch V2 2/4] atomics: Provide atomic_add_and_negative() variants Thomas Gleixner
2023-03-22 13:20   ` Mark Rutland
2023-03-07 12:57 ` [patch V2 3/4] atomics: Provide rcuref - scalable reference counting Thomas Gleixner
2023-03-09  8:35   ` Qiuxu Zhuo
2023-03-20 16:05     ` Thomas Gleixner
2023-03-07 12:57 ` [patch V2 4/4] net: dst: Switch to rcuref_t " Thomas Gleixner
2023-03-07 17:55   ` Linus Torvalds
2023-03-07 23:00     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f97f6d5-d979-d501-a090-b5a69f33fa45@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).