From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75711C7618B for ; Wed, 15 Mar 2023 16:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232529AbjCOQIh (ORCPT ); Wed, 15 Mar 2023 12:08:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232721AbjCOQIS (ORCPT ); Wed, 15 Mar 2023 12:08:18 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 160449312A for ; Wed, 15 Mar 2023 09:07:50 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id eh3so21629993edb.11 for ; Wed, 15 Mar 2023 09:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678896467; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aqONjTIvP+09QATy3Q2cw95EblEgzACspeULoqIwV9Y=; b=lIMiWV12PehHR4iYXCo/jDBJIM8iQ6sQlPaNKH7s+WMyCt4ZZLUFY7lFuqV343vIln uDCIipG8HMkzP5WRTTs6kl/Sk3QgeeWeWM4gNX1aO+OzeMA1NUv7YOSf/NKheL1f+NSn xPAySfY7tXsw4giQ9LUofs+AMrKx0ez6U0tZFD1930ytPKwH2NxNe/DRIYjkUzRjJ+BH XjoObNaLwVniKtZV/nkxVfxMnYn+K6bAQdyw3ID8yqk1fWlpdU2KSHKRLHSA1+K2W2y0 zTMO1IHFuD45roeCdYA+nT5c2WOEIXVlnltB5Q4V2KNIVuIEaDCbhd2ua4W2Ygbbcyxw vIfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678896467; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aqONjTIvP+09QATy3Q2cw95EblEgzACspeULoqIwV9Y=; b=6+hUL5jGlgejpCzXXgBnpsWwBomaTAOSvMqTEG/pMhUAFeRMP8j7tC2WuwIEofxzr0 xqSt4spiwNDtqa7ttkagX9kxvOvSPX3L2ueMlKnJ7/hAoxZ6lqTvmiJKVfT/0TplvyIU s48358nZRwW3uXqFy3frs2DGV4Ds53fsk5hI3D5hi58r/7Us2DaKtZBz70xAK9kUR5qo cId9uaMUhO8Hf3Ydf0BsCJuqJExDyoW7yLer2sGvBxOcRJbD0lKQxvK0FShkYZOKFdKQ TO6A0J9/+6WITWP8bC7TAs5fxzliGEalNeDJww02kA7hyp6HO2V+ERf975pHeptcqtiK 2MZw== X-Gm-Message-State: AO0yUKWwMnd510O+KhCJdhb2dhoPRVXZaidUm91y3tl5TBNU7epvqjAD OZZzzn13vWXEfljOCRG/DD5Ntg== X-Google-Smtp-Source: AK7set/V5QhWp204qp4YKQAWWSWsqvv9kVX1BvemQkrh+PYjnSB+cybioLWeTxDRDvN5lesy2ZIUqw== X-Received: by 2002:a17:906:a843:b0:928:3d04:c7e6 with SMTP id dx3-20020a170906a84300b009283d04c7e6mr6422908ejb.26.1678896467510; Wed, 15 Mar 2023 09:07:47 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:940e:8615:37dc:c2bd? ([2a02:810d:15c0:828:940e:8615:37dc:c2bd]) by smtp.gmail.com with ESMTPSA id u11-20020a1709060b0b00b008e22978b98bsm2706446ejg.61.2023.03.15.09.07.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 09:07:47 -0700 (PDT) Message-ID: <5f9fe7fb-9483-7dee-82c8-bd6564abcaab@linaro.org> Date: Wed, 15 Mar 2023 17:07:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/5] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants Content-Language: en-US To: Markus Schneider-Pargmann Cc: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger , Rob Herring , Krzysztof Kozlowski , Vincent MAILHOL , Simon Horman , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230314151201.2317134-1-msp@baylibre.com> <20230314151201.2317134-2-msp@baylibre.com> <680053bc-66fb-729f-ecdc-2f5fe511cecd@linaro.org> <20230315112508.6q52rekhmk66uiwj@pengutronix.de> <54aae3b8-ee85-c7eb-ecda-f574cb140675@linaro.org> <20230315155833.qsb5t367on5hl5li@blmsp> From: Krzysztof Kozlowski In-Reply-To: <20230315155833.qsb5t367on5hl5li@blmsp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 15/03/2023 16:58, Markus Schneider-Pargmann wrote: > On Wed, Mar 15, 2023 at 02:14:27PM +0100, Krzysztof Kozlowski wrote: >> On 15/03/2023 12:25, Marc Kleine-Budde wrote: >>> On 14.03.2023 21:01:10, Krzysztof Kozlowski wrote: >>>> On 14/03/2023 16:11, Markus Schneider-Pargmann wrote: >>>>> These two new chips do not have state or wake pins. >>>>> >>>>> Signed-off-by: Markus Schneider-Pargmann >>>>> --- >>>>> .../devicetree/bindings/net/can/tcan4x5x.txt | 11 ++++++++--- >>>>> 1 file changed, 8 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>>>> index e3501bfa22e9..38a2b5369b44 100644 >>>>> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>>>> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>>>> @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller >>>>> This file provides device node information for the TCAN4x5x interface contains. >>>>> >>>>> Required properties: >>>>> - - compatible: "ti,tcan4x5x" >>>>> + - compatible: >>>>> + "ti,tcan4x5x" or >>>>> + "ti,tcan4552" or >>>>> + "ti,tcan4553" >>>> >>>> Awesome, they nicely fit into wildcard... Would be useful to deprecate >>>> the wildcard at some point and switch to proper compatibles in such >>>> case, because now they became confusing. >>> >>> I plead for DT stability! >>> >>> As I understand correctly, the exact version of the chip (4550, 4552, or >>> 4553) can be detected via the ID2 register. >> >> So maybe there is no need for this patch at all? Or the new compatibles >> should be made compatible with generic fallback? > > I can use the value being read from the ID2 register to get the version. > This at least holds the correct value for tcan4550, 4552 and 4553. But > the state and wake gpios can't be used in case of a 4552 or 4553. > > So yes, it is possible to do it without the new compatibles but the > changes for state and wake gpios need to stay. > > What do you two prefer? Then specific with generic fallback compatibles, although for driver it still won't matter as you need to customize driver_data anyway. Best regards, Krzysztof