From: "Rangoju, Raju" <raju.rangoju@amd.com>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch
Subject: Re: [PATCH net 2/2] amd-xgbe: add PCI power management for S0i3 support
Date: Thu, 26 Feb 2026 21:12:37 +0530 [thread overview]
Message-ID: <5fb06bfd-7bc0-4c2f-b1b6-1fd33990dd0d@amd.com> (raw)
In-Reply-To: <aaA-xiedBzGqx9HY@horms.kernel.org>
On 2/26/2026 6:08 PM, Simon Horman wrote:
>> ---
>> drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 39 ++++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
>> index 112d7697174c..8e392cccd065 100644
>> --- a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
>> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
>> @@ -356,15 +356,34 @@ static int xgbe_pci_suspend(struct device *dev)
>> {
>> struct xgbe_prv_data *pdata = dev_get_drvdata(dev);
>> struct net_device *netdev = pdata->netdev;
>> + struct pci_dev *pdev = to_pci_dev(dev);
>> int ret = 0;
>>
>> + if (!netdev)
>> + return 0;
>> +
>
> Can netdev be NULL here?
> Same question for the check in xgbe_pci_resume().
>
Sure Simon, will fix it and submit to net-next as this patch is an
enhancement.
prev parent reply other threads:[~2026-02-26 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 10:59 [PATCH net 0/2] amd-xgbe: fix S0i3 suspend/resume issues Raju Rangoju
2026-02-25 11:00 ` [PATCH net 1/2] amd-xgbe: fix sleep while atomic on suspend/resume Raju Rangoju
2026-02-26 12:37 ` Simon Horman
2026-02-26 15:37 ` Rangoju, Raju
2026-02-26 12:40 ` Simon Horman
2026-02-26 15:39 ` Rangoju, Raju
2026-02-25 11:00 ` [PATCH net 2/2] amd-xgbe: add PCI power management for S0i3 support Raju Rangoju
2026-02-26 12:38 ` Simon Horman
2026-02-26 15:42 ` Rangoju, Raju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fb06bfd-7bc0-4c2f-b1b6-1fd33990dd0d@amd.com \
--to=raju.rangoju@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox