From: Paolo Abeni <pabeni@redhat.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"Colin Foster" <colin.foster@in-advantage.com>,
"Roopa Prabhu" <roopa@nvidia.com>,
"Nikolay Aleksandrov" <razor@blackwall.org>,
"Tobias Waldekranz" <tobias@waldekranz.com>,
"Marek Behún" <kabel@kernel.org>,
"Ansuel Smith" <ansuelsmth@gmail.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Felix Fietkau" <nbd@nbd.name>, "John Crispin" <john@phrozen.org>,
"Sean Wang" <sean.wang@mediatek.com>,
"David Ahern" <dsahern@kernel.org>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: Re: [PATCH v2 net-next 03/10] net: dsa: allow the DSA master to be seen and changed through rtnetlink
Date: Tue, 20 Sep 2022 11:24:57 +0200 [thread overview]
Message-ID: <5fb488a102d0738ab153bf133439dd64f09d096e.camel@redhat.com> (raw)
In-Reply-To: <20220911143554.tq4lf5eqs4novhtn@skbuf>
Hello,
On Sun, 2022-09-11 at 14:35 +0000, Vladimir Oltean wrote:
> On Sun, Sep 11, 2022 at 04:06:59AM +0300, Vladimir Oltean wrote:
> > +struct rtnl_link_ops dsa_link_ops __read_mostly = {
> > + .kind = "dsa",
> > + .priv_size = sizeof(struct dsa_port),
> > + .maxtype = IFLA_DSA_MAX,
> > + .policy = dsa_policy,
> > + .changelink = dsa_changelink,
> > + .get_size = dsa_get_size,
> > + .fill_info = dsa_fill_info,
> > +};
>
> I forgot to apply Jakub's suggestion to set netns_refund = true.
> On the other hand, I think the patches are otherwise fine, and I
> wouldn't resend them, especially without any feedback. If there is no
> other feedback, can I fix this up through an incremental patch?
Since the delta should be minimal, we have a significant backlog, and
this LGTM, I'm going to apply the series as-is.
Please follow-up with the incremental fix, thanks,
Paolo
next prev parent reply other threads:[~2022-09-20 9:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 1:06 [PATCH v2 net-next 00/10] DSA changes for multiple CPU ports (part 4) Vladimir Oltean
2022-09-11 1:06 ` [PATCH v2 net-next 01/10] net: introduce iterators over synced hw addresses Vladimir Oltean
2022-09-11 1:06 ` [PATCH v2 net-next 02/10] net: dsa: introduce dsa_port_get_master() Vladimir Oltean
2022-09-11 1:06 ` [PATCH v2 net-next 03/10] net: dsa: allow the DSA master to be seen and changed through rtnetlink Vladimir Oltean
2022-09-11 14:35 ` Vladimir Oltean
2022-09-20 9:24 ` Paolo Abeni [this message]
2022-09-11 1:07 ` [PATCH v2 net-next 04/10] net: dsa: don't keep track of admin/oper state on LAG DSA masters Vladimir Oltean
2022-09-11 1:07 ` [PATCH v2 net-next 05/10] net: dsa: suppress appending ethtool stats to " Vladimir Oltean
2022-09-11 1:07 ` [PATCH v2 net-next 06/10] net: dsa: suppress device links " Vladimir Oltean
2022-09-11 1:07 ` [PATCH v2 net-next 07/10] net: dsa: propagate extack to port_lag_join Vladimir Oltean
2022-09-11 1:07 ` [PATCH v2 net-next 08/10] net: dsa: allow masters to join a LAG Vladimir Oltean
2022-09-11 1:07 ` [PATCH v2 net-next 09/10] docs: net: dsa: update information about multiple CPU ports Vladimir Oltean
2022-09-11 1:07 ` [PATCH v2 net-next 10/10] net: dsa: felix: add support for changing DSA master Vladimir Oltean
2022-09-20 9:40 ` [PATCH v2 net-next 00/10] DSA changes for multiple CPU ports (part 4) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fb488a102d0738ab153bf133439dd64f09d096e.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=sean.wang@mediatek.com \
--cc=stephen@networkplumber.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).