From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D88522F388; Sun, 3 May 2026 03:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777778115; cv=none; b=lSf2N4omdgXZyZhshmcGa018QOXhi8lLsh6h8GQnNh1APRJA6Ld0ICDNfzsAo4w0Oll92hvRRH7qqrRVqEQd1Q4dcNAU+u2sNG8ZUMhb0r6PxFcm4ffLEp6wZcSlMCezuB1IKiAR8uNjbssIPkXI+sxcDaeOHVsQejVQH0z1LvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777778115; c=relaxed/simple; bh=uszX8nktAYPhBwqPGg9ArZG92U7lZm0cjvtfUsKt9IQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dnmwtErkLfTEcSw1JuTam4bNOVvY8HhEoadg5oDzXYWJvvIj6SXq213GVOb0X8I6SuYJ53HYO5L1bYiT1LwHSs+nd0qXz5R2iSPVSNOhsSOsjrlN9t7gUHhIn8ut4aDKakarSTBJjddBD+ujkQ0TNnVA1FpQ1jQmhakPcyQYFAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=X1Fze2et; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="X1Fze2et" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=3Ud8a0f7cDkt/L/85rROuudOvlxnH0qdkSWe2s+aBps=; b=X1Fze2et52QjyiV6ocLwbVnDp6 Mu8ZoBovYc0lzK8m/eV2ysKglzRfhE/eeXeW0IG6MZzanNENe+5dv3d/gY8XDucWrZTLFNVBzTLTF G4BkuygvqDpXvB8y0sVfEPYBjAsnsKSTBXtRWb4Df1fvcFTlj9iFFAsedarC0I+Z8Spo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wJNIM-0015GF-IK; Sun, 03 May 2026 05:15:02 +0200 Date: Sun, 3 May 2026 05:15:02 +0200 From: Andrew Lunn To: ciprian.regus@analog.com Cc: Parthiban Veerasooran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Heiner Kallweit , Russell King , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 4/5] net: ethernet: adi: Add a driver for the ADIN1140 MACPHY Message-ID: <5fb5e72c-2cd3-4582-afa5-eec1ea6ab84d@lunn.ch> References: <20260503-adin1140-driver-v1-0-dd043cdd88f0@analog.com> <20260503-adin1140-driver-v1-4-dd043cdd88f0@analog.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260503-adin1140-driver-v1-4-dd043cdd88f0@analog.com> > +enum adin1140_statistics_entry { > + rx_frames, > + rx_broadcast_frames, > + rx_multicast_frames, > + rx_unicast_frames, > + rx_crc_errors, > + rx_align_errors, > + rx_preamble_errors, > + rx_short_frame_errors, > + rx_long_frame_errors, > + rx_phy_errors, > + rx_fifo_full_dropped, > + rx_addr_filter_dropped, > + rx_ifg_errors, > + tx_frames, > + tx_broadcast_frames, > + tx_multicast_frames, > + tx_unicast_frames, > + tx_single_collision, > + tx_multi_collision, > + tx_deferred, > + tx_late_collision, > + tx_excess_collision, > + tx_underrun, > +}; Many of these seem to be ethtool_eth_mac_stats. Please use that to report the. You should only use the free form strings/values for none standard statistics. Andrew