From: Eric Dumazet <eric.dumazet@gmail.com>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>,
netdev@vger.kernel.org, mptcp@lists.01.org
Subject: Re: [PATCH net-next v3 07/11] tcp: Prevent coalesce/collapse when skb has MPTCP extensions
Date: Wed, 18 Dec 2019 11:50:24 -0800 [thread overview]
Message-ID: <5fc0d4bd-5172-298d-6bbb-00f75c7c0dc9@gmail.com> (raw)
In-Reply-To: <20191217203807.12579-8-mathew.j.martineau@linux.intel.com>
On 12/17/19 12:38 PM, Mat Martineau wrote:
> The MPTCP extension data needs to be preserved as it passes through the
> TCP stack. Make sure that these skbs are not appended to others during
> coalesce or collapse, so the data remains associated with the payload of
> the given skb.
>
This seems a very pessimistic change to me.
Are you planing later to refine this limitation ?
Surely if a sender sends TSO packet, we allow all the segments
being aggregated at receive side either by GRO or TCP coalescing.
next prev parent reply other threads:[~2019-12-18 19:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 20:37 [PATCH net-next v3 00/11] Multipath TCP: Prerequisites Mat Martineau
2019-12-17 20:37 ` [PATCH net-next v3 01/11] net: Make sock protocol value checks more specific Mat Martineau
2019-12-17 20:37 ` [PATCH net-next v3 02/11] sock: Make sk_protocol a 16-bit value Mat Martineau
2019-12-17 20:37 ` [PATCH net-next v3 03/11] tcp: Define IPPROTO_MPTCP Mat Martineau
2019-12-17 20:38 ` [PATCH net-next v3 04/11] tcp: Add MPTCP option number Mat Martineau
2019-12-17 20:38 ` [PATCH net-next v3 05/11] tcp, ulp: Add clone operation to tcp_ulp_ops Mat Martineau
2019-12-17 20:38 ` [PATCH net-next v3 06/11] mptcp: Add MPTCP to skb extensions Mat Martineau
2019-12-17 20:38 ` [PATCH net-next v3 07/11] tcp: Prevent coalesce/collapse when skb has MPTCP extensions Mat Martineau
2019-12-18 19:50 ` Eric Dumazet [this message]
2019-12-18 20:45 ` David Miller
2019-12-18 21:02 ` Mat Martineau
2019-12-18 21:36 ` subashab
2019-12-18 21:52 ` Paolo Abeni
2019-12-18 22:15 ` [MPTCP] " Paolo Abeni
2019-12-18 23:17 ` David Miller
2019-12-17 20:38 ` [PATCH net-next v3 08/11] tcp: Export TCP functions and ops struct Mat Martineau
2019-12-17 20:38 ` [PATCH net-next v3 09/11] tcp: Check for filled TCP option space before SACK Mat Martineau
2019-12-17 20:38 ` [PATCH net-next v3 10/11] tcp: clean ext on tx recycle Mat Martineau
2019-12-17 20:38 ` [PATCH net-next v3 11/11] skb: add helpers to allocate ext independently from sk_buff Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc0d4bd-5172-298d-6bbb-00f75c7c0dc9@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox