From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mi Subject: Re: [patch iproute2 v4 3/3] man: Add -bs option to tc manpage Date: Wed, 3 Jan 2018 10:48:56 +0800 Message-ID: <5fc53586-cf93-a74d-8eb3-27cb0a704b8a@mellanox.com> References: <20180102142804.27145-1-chrism@mellanox.com> <20180102142804.27145-4-chrism@mellanox.com> <20180102200718.GB725@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, gerlitz.or@gmail.com, stephen@networkplumber.org, dsahern@gmail.com To: Marcelo Ricardo Leitner Return-path: Received: from mail-he1eur01on0078.outbound.protection.outlook.com ([104.47.0.78]:23776 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750997AbeACCtK (ORCPT ); Tue, 2 Jan 2018 21:49:10 -0500 In-Reply-To: <20180102200718.GB725@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: 2018/1/3 4:07, Marcelo Ricardo Leitner: > On Tue, Jan 02, 2018 at 11:28:04PM +0900, Chris Mi wrote: >> Signed-off-by: Chris Mi >> --- >> man/man8/tc.8 | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/man/man8/tc.8 b/man/man8/tc.8 >> index ff071b33..de137e16 100644 >> --- a/man/man8/tc.8 >> +++ b/man/man8/tc.8 >> @@ -601,6 +601,11 @@ must exist already. >> read commands from provided file or standard input and invoke them. >> First failure will cause termination of tc. >> >> +.TP >> +.BR "\-bs", " \-bs size", " \-batchsize", " \-batchsize size" >> +How many commands are accumulated before sending to kernel. >> +By default, it is 1. It only takes effect in batch mode. >> + > You should also describe the limitations it has. Like, it only works > for action and filter and that it shouldn't be mixed with other > commands. Done. > And maybe even do such check in the code: refuse to do other commands > if batch_size > 1. I didn't add it because I'm afraid the benefit may be gone if I add the check. But I add a warning in the man page. > >> .TP >> .BR "\-force" >> don't terminate tc on errors in batch mode. >> -- >> 2.14.3 >>