From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH bpf v3 3/5] selftests/bpf: test_sockmap, fix test timeout Date: Wed, 30 May 2018 06:31:08 -0700 Message-ID: <5fdb7801-496e-81fb-dd34-c255a5290384@gmail.com> References: <20180530055611.10216-1-bhole_prashant_q7@lab.ntt.co.jp> <20180530055611.10216-4-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , Shuah Khan , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org To: Prashant Bhole , Alexei Starovoitov , Daniel Borkmann Return-path: Received: from mail-it0-f68.google.com ([209.85.214.68]:54600 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbeE3NbX (ORCPT ); Wed, 30 May 2018 09:31:23 -0400 In-Reply-To: <20180530055611.10216-4-bhole_prashant_q7@lab.ntt.co.jp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/29/2018 10:56 PM, Prashant Bhole wrote: > In order to reduce runtime of tests, recently timout for select() call > was reduced from 1sec to 10usec. This was causing many tests failures. > It was caught with failure handling commits in this series. > > Restoring the timeout from 10usec to 1sec > > Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests") > Signed-off-by: Prashant Bhole > --- Quick question, how long does it take to run now with the time increase? If its taking too long we may need to remove some tests. I have a longer running test_sockmap script that I run as part of Cilium[1] project where I put longer running stress tests. Acked-by: John Fastabend [1] cilium.io