From: Paolo Abeni <pabeni@redhat.com>
To: Birger Koblitz <mail@birger-koblitz.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] r8152: Add support for the RTL8157 hardware
Date: Tue, 24 Mar 2026 11:58:17 +0100 [thread overview]
Message-ID: <5ff51617-deb6-48b0-b9e2-2d7066fa2562@redhat.com> (raw)
In-Reply-To: <20260320-rtl8157_next-v3-2-1aefeca7fda7@birger-koblitz.de>
On 3/20/26 12:14 PM, Birger Koblitz wrote:
> @@ -2022,14 +2277,14 @@ static void intr_callback(struct urb *urb)
> }
> }
>
> -static inline void *rx_agg_align(void *data)
> +static inline void *rx_agg_align(struct r8152 *tp, void *data)
> {
> - return (void *)ALIGN((uintptr_t)data, RX_ALIGN);
> + return (void *)ALIGN((uintptr_t)data, tp->rx_desc.align);
> }
>
> -static inline void *tx_agg_align(void *data)
> +static inline void *tx_agg_align(struct r8152 *tp, void *data)
Since you are touching this functions, in the next revision please
additionally drop the 'inline' keyword; the compiler should be good
enough to get them inlined anyway.
/P
next prev parent reply other threads:[~2026-03-24 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 11:14 [PATCH net-next v3 0/2] r8152: Add support for the RTL8157 5Gbit USB Ethernet chip Birger Koblitz
2026-03-20 11:14 ` [PATCH net-next v3 1/2] r8152: Add support for 5Gbit Link Speeds and EEE Birger Koblitz
2026-03-24 10:55 ` [net-next,v3,1/2] " Paolo Abeni
2026-03-24 15:49 ` Birger Koblitz
2026-03-20 11:14 ` [PATCH net-next v3 2/2] r8152: Add support for the RTL8157 hardware Birger Koblitz
2026-03-24 10:55 ` [net-next,v3,2/2] " Paolo Abeni
2026-03-24 16:55 ` Birger Koblitz
2026-03-24 10:58 ` Paolo Abeni [this message]
2026-03-24 17:00 ` [PATCH net-next v3 2/2] " Birger Koblitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ff51617-deb6-48b0-b9e2-2d7066fa2562@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@birger-koblitz.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox