From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] net: sched: cls_api: fix dead code in switch Date: Thu, 26 Jul 2018 16:32:01 -0500 Message-ID: <6021c3c3-dc4a-ec09-a0dc-23ff548fa9f1@embeddedor.com> References: <20180725140724.GA23053@embeddedor.com> <20180726.141022.1379401977396818228.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: jiri@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20180726.141022.1379401977396818228.davem@davemloft.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 07/26/2018 04:10 PM, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Wed, 25 Jul 2018 09:07:24 -0500 > >> Code at line 1850 is unreachable. Fix this by removing the break >> statement above it, so the code for case RTM_GETCHAIN can be >> properly executed. >> >> Addresses-Coverity-ID: 1472050 ("Structurally dead code") >> Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi") >> Signed-off-by: Gustavo A. R. Silva > > Applied, thanks. > > Please use "[PATCH net-next] ..." in your subject lines to indirect > the tree that this change is relevant for and targetted to. > Got it. Will do next time. Thanks -- Gustavo