From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 237FA2C6A9 for ; Fri, 15 Dec 2023 12:19:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="b7OFAgPw" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-54c5ed26cf6so684078a12.3 for ; Fri, 15 Dec 2023 04:19:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702642744; x=1703247544; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5CUwV9YzDjk7TETgRBF+vAn2dGINEGLjHwV0E2neeSk=; b=b7OFAgPwC1hRpBwrda4kZUV64Dub4bkOfhdpW2Oo7AjC3W1rS6egwJZNNnXOG2Y72Z XIjUMINrK+N25LiOF7bUOhKNsSQrt94PnflTvBe3i7rPzYTlzTIUQOiUVH4WRWwtuujZ hlr838qx3mP5b9rMHDo/ron11CAAmX7uxleXvoIwybU9r1M6RFvdF6H1AYVdwrbUTZVq Y4UscGODtCeUoIw3mH19wwvMqsBRLs+0Gib6rreVQrDG6edtksBU7XSiqQIjTLS/VWhL htTZL9yP6nPO1wZS3xETwbC9rZMXAMDtqhw98HR5I6PXBYTWJKvmkqg3vc8rAGLYDauz NObw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702642744; x=1703247544; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5CUwV9YzDjk7TETgRBF+vAn2dGINEGLjHwV0E2neeSk=; b=PfWJe8fXTnFPpY8cKolJjC5whkqLt2EcfdTNO5kogmNUuW7eX6w35O5ogpp3WgZJdE jr6XQ7nGrKXHBNouWJBP4/4VMNaF3t6k2ppaH8I9vTWMEH6Hs5fa2akMXxySMgN52kK2 rQ9RDT8uYrdjHKKSyUx8hGi2Obp0iZtSonr0fRjC4/LcdmCUWChbAKEsRMSKt6hbXGUQ //l1g7gYHUTfzLAlCGdYV4FE/HP9pbms4d4Fta4HCG4+eU1taWqzLNm+TVKLPgjDrnHd 2fPhp++Sd2i153oHI8coH3/womJ6FlTUJysi0sVGozDAU8t5pSpBUKeFsxXC9Wxxs9Af rA8g== X-Gm-Message-State: AOJu0Yx2zC60MqMQldiyel9XoyOwHTaYDSsnYs8CkJz38aB9XtYQsBAN cCXKeGuxWWyBAHyC+q7ty8YSlg== X-Google-Smtp-Source: AGHT+IGog3jaPmnLXma+JOhrfipO/UbvgnPSlbvmi52+7OecVpyJP+hC70VOo8PO7Kn+oY9Q7gCovQ== X-Received: by 2002:a17:907:2d8c:b0:a1e:7770:2c7c with SMTP id gt12-20020a1709072d8c00b00a1e77702c7cmr8060497ejc.100.1702642744447; Fri, 15 Dec 2023 04:19:04 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id ry9-20020a1709068d8900b00a1f7470ba93sm9908234ejc.200.2023.12.15.04.19.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 04:19:03 -0800 (PST) Message-ID: <602759ce-c93d-4111-9272-1dce7e4a170a@linaro.org> Date: Fri, 15 Dec 2023 13:19:01 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332 platform Content-Language: en-US To: Jie Luo , Conor Dooley Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, robert.marko@sartura.hr, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_srichara@quicinc.com References: <20231212115151.20016-1-quic_luoj@quicinc.com> <20231212115151.20016-6-quic_luoj@quicinc.com> <20231212-caution-improvise-ed3cc6a1d305@spud> <11ffc985-3f2b-46b9-ae0b-911f7abe98d1@quicinc.com> <20231214-outshine-shush-8a11c68607cd@spud> <26c8b0b1-5ea9-45cc-adf3-0d0b03a1284d@linaro.org> <4b9c56b8-3b29-4861-a3d5-2da26fbc14b4@quicinc.com> <2e77e3b1-00b6-46b9-bfed-7cae3ffa15e9@linaro.org> <7bae46fd-63fd-4b86-9a56-73052cf0ea95@quicinc.com> <5a8095e6-b6a6-4d11-b006-31519e8d8622@linaro.org> <7466b655-2b7e-44f2-a510-6e0cc1b95248@quicinc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <7466b655-2b7e-44f2-a510-6e0cc1b95248@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/12/2023 12:42, Jie Luo wrote: >>>>>>>> Which clocks are these mentioned in the property? From where do they come? >>>>>>>> >>>>>>>> Anyway, property is in existing form is not correct - this is not a >>>>>>>> generic property. >>>>>>>> >>>>>>> >>>>>>> This property cmn-reference-clock is just the hardware register >>>>>>> configuration, since the different IPQ platform needs to select >>>>>>> the different reference clock source for the CMN PLL block that >>>>>>> provides the various clock outputs to the all kinds of Ethernet >>>>>>> devices, which is not from GCC provider. >>>>>> >>>>>> AGAIN: where do the clocks come from? Which device generates them? >>>>> >>>>> Oh, OK, the reference clock is from wifi that provides 48MHZ to >>>>> Ethernet block. >>>> >>>> Then WiFi should be providing you the clock and this device should be >>>> clock consumer, right? >>> >>> Yes, wifi provides 48MHz clock to CMM PLL block, there is no GCC >>> for this 48MHZ clock output, it is the hardware PIN connection. >> >> All clocks are some hardware pin connections. >> >> Best regards, >> Krzysztof >> > > Yes, all reference clocks here are from hardware pin connection. You keep answering with short sentences without touching the root of the problem. I don't know exactly why, but I feel this discussion leads nowhere. After long discussion you finally admitted that clocks came from another device - Wifi. It took us like 6 emails? So last statement: if you have clock provider and clock consumer, you must represent it in the bindings or provide rationale why it should not or must not be represented in the bindings. So far I do not see any of such arguments. If you use arguments like: "My driver....": sorry, bindings are not about drivers "I don't have clock driver for WiFi": sorry, it does not matter if you can write one, right? Please reach internally your colleagues to solve these problems and make review process smoother. Best regards, Krzysztof