netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: Frank Li <Frank.li@nxp.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format
Date: Mon, 2 Jun 2025 21:28:02 +0200	[thread overview]
Message-ID: <602cc521-9b7e-424b-8956-429d654fc760@gmx.net> (raw)
In-Reply-To: <aD3E2ONB6Ay1wwmk@lizhi-Precision-Tower-5810>

Hi Frank,

Am 02.06.25 um 17:35 schrieb Frank Li:
> On Fri, May 30, 2025 at 10:33:28AM +0200, Stefan Wahren wrote:
>> Hi Frank,
>>
>> thanks for this patch.
>>
>> Am 29.05.25 um 21:17 schrieb Frank Li:
...
>>> +  - Frank Li <Frank.Li@nxp.com>
>>> +
>>> +description: |
>>> +  The QCA7000 is a serial-to-powerline bridge with a host interface which could
>>> +  be configured either as SPI or UART slave. This configuration is done by
>>> +  the QCA7000 firmware.
>>> +
>>> +  (a) Ethernet over SPI
>>> +
>>> +  In order to use the QCA7000 as SPI device it must be defined as a child of a
>>> +  SPI master in the device tree.
>> Could you please add the dropped "(b) Ethernet over UART" description here?
> Okay, I will add back.
>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: qca,qca7000
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  spi-cpha: true
>>> +
>>> +  spi-cpol: true
>> In case of a SPI setup these properties should be required. Unfortunately
>> i'm not sure how to enforce this. Maybe depending on the presence of "reg"?
> But It think depend on reg is not good idea, which too obscure.
I understand, but this was the first idea which comes to my mind.
>   Ideally it
> should be use two compatible strings. It should treat as two kinds device.
Back in the days there was a discussion about different compatible 
strings and it was rejected [1].
> It is really old devices and not worth to update compatible string.
Yes, this powerline communication chip was introduced in 2012 but it's 
very widespread. Most of the electric vehicles and DC charging stations 
use this chip.

Regards

[1] - https://lkml.org/lkml/2017/5/19/390
>
> Maybe some one in dt team can provide suggestion!
>
> Rob and Krzysztof Kozlowski:
>    any idea about this?
>
> Frank

  reply	other threads:[~2025-06-02 19:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 19:17 [PATCH 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format Frank Li
2025-05-30  8:33 ` Stefan Wahren
2025-06-02 15:35   ` Frank Li
2025-06-02 19:28     ` Stefan Wahren [this message]
2025-06-02 20:21     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=602cc521-9b7e-424b-8956-429d654fc760@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=Frank.li@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).