From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97EECC433DB for ; Thu, 18 Feb 2021 06:20:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 502CE64E2E for ; Thu, 18 Feb 2021 06:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbhBRGRN (ORCPT ); Thu, 18 Feb 2021 01:17:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232004AbhBRGKG (ORCPT ); Thu, 18 Feb 2021 01:10:06 -0500 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D81FC061574; Wed, 17 Feb 2021 22:09:05 -0800 (PST) Received: by mail-io1-xd2e.google.com with SMTP id u20so875294iot.9; Wed, 17 Feb 2021 22:09:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=atQAOiXOaMqgkt/WAy6i7CPw9uCPqigPDIhb+m8D4Y8=; b=nxC60e/uUY4jw8+FJ0kmQWgUsuJGK5wdf9HeGp2FM0gZei3SirMeYsXmQ8XlDIR04l L6mtzeOBsFhv9c2EKURuPpuOXsfGgZQLLZmCyDAfnP2HTft3XWGKKqX2DWiMvs3WNdZ+ EutwcGVe9QKoXc4bwbY5A/zwZM5ajqgNseOweUvPgGfgM/gVSOYvwm/4FzGan29lH4cO S5GZopYOy0XuXQ9LbvdyyJyd0pS63ylKBXmx1jgutD99r5lmBWCG76ANFPOfblwNjDnz a4q4n9jIesPN5al1RmTCCFbBFprYVSGYqpYJB27XgjWpD9y/jDzOHEMjlKrT5/eFeIfi 4zTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=atQAOiXOaMqgkt/WAy6i7CPw9uCPqigPDIhb+m8D4Y8=; b=tp8h5FO0kNIx2ROeLvRw/4Z6ajrWwPrEC1f0XoMeIA6QHO3ToYS/1YqqgtU2CjtPPK iL0ZGzJNoFtStW6BLGq1Za4FrTbNcv4/zRgCcG1bcPlaF61E7CWc3isAimy1Y2YcONf2 8EcqLeXxY5sJL9Qlg7U4ofWznSLAkqy16f17mlAU9Qu3tV15oEbAhPZf+RNoWsLKqTgf +dhC1EM/YR08Cqk5e8U05uVCp2ueqjfAmdn86vzTqqOfzG/HN9OvkZgNynuZ+8L9xuIm z9T+AIyfSUQIBzlRNnUmpqgCHuIXMBowM78fPajLg+IOWqAfQs5Fr4VMKuTfGbJnCe70 4WUw== X-Gm-Message-State: AOAM533BwbcEOPgICCnMRCEoTZajr2IZhm0c21oF9bAZ51HJ7vICivzw eGr/HyiAQ6o3vzAF0zp9LfY= X-Google-Smtp-Source: ABdhPJyWEr2p5NJfyVcac6POCKwY2UVRF2my+lH+aP4hrOuC6NQOqiSfIPl7hpFEPYSDm9t0Vn/2vQ== X-Received: by 2002:a05:6638:33a0:: with SMTP id h32mr3133952jav.143.1613628544803; Wed, 17 Feb 2021 22:09:04 -0800 (PST) Received: from localhost ([172.243.146.206]) by smtp.gmail.com with ESMTPSA id w5sm3220548ilj.40.2021.02.17.22.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 22:09:04 -0800 (PST) Date: Wed, 17 Feb 2021 22:08:55 -0800 From: John Fastabend To: Alexander Lobakin , Daniel Borkmann , Magnus Karlsson Cc: "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jonathan Lemon , Alexei Starovoitov , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Paolo Abeni , Eric Dumazet , Xuan Zhuo , Dust Li , Alexander Lobakin , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Message-ID: <602e0477af4c2_1f0ef2088e@john-XPS-13-9370.notmuch> In-Reply-To: <20210217120003.7938-1-alobakin@pm.me> References: <20210217120003.7938-1-alobakin@pm.me> Subject: RE: [PATCH v7 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit) Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Alexander Lobakin wrote: > This series introduces XSK generic zerocopy xmit by adding XSK umem > pages as skb frags instead of copying data to linear space. > The only requirement for this for drivers is to be able to xmit skbs > with skb_headlen(skb) == 0, i.e. all data including hard headers > starts from frag 0. > To indicate whether a particular driver supports this, a new netdev > priv flag, IFF_TX_SKB_NO_LINEAR, is added (and declared in virtio_net > as it's already capable of doing it). So consider implementing this > in your drivers to greatly speed-up generic XSK xmit. [...] > ---------------- Performance Testing ------------ > > The test environment is Aliyun ECS server. > Test cmd: > ``` > xdpsock -i eth0 -t -S -s > ``` > > Test result data: > > size 64 512 1024 1500 > copy 1916747 1775988 1600203 1440054 > page 1974058 1953655 1945463 1904478 > percent 3.0% 10.0% 21.58% 32.3% > For the series, but might be good to get Dave or Jakub to check 2/6 to be sure they agree. Acked-by: John Fastabend