From: David Ahern <dsahern@gmail.com>
To: Girish Moodalbail <girish.moodalbail@oracle.com>,
netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH v2 iproute2] lib: Dump ext-ack string by default
Date: Wed, 9 Aug 2017 08:03:24 -0600 [thread overview]
Message-ID: <602fa731-bc27-9748-2b7a-48274be529d9@gmail.com> (raw)
In-Reply-To: <9bc620b6-cd6e-a65e-7079-bb4d757312c4@oracle.com>
On 8/9/17 1:38 AM, Girish Moodalbail wrote:
>> @@ -99,7 +95,16 @@ static int nl_dump_ext_err(const struct nlmsghdr
>> *nlh, nl_ext_ack_fn_t errfn)
>> err_nlh = &err->msg;
>> }
>> - return errfn(errmsg, off, err_nlh);
>> + if (errfn)
>> + return errfn(errmsg, off, err_nlh);
>> +
>> + if (errmsg) {
>> + fprintf(stderr, "Error: %s\n", errmsg);
>
> Should the above output end with a period '.'? All the error messages in
> the Kernel are statements without a terminating period, so the output
no guarantee of that, but iproute2 could check for it and add it.
prev parent reply other threads:[~2017-08-09 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 14:30 [PATCH v2 iproute2] lib: Dump ext-ack string by default David Ahern
2017-08-09 7:38 ` Girish Moodalbail
2017-08-09 14:03 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=602fa731-bc27-9748-2b7a-48274be529d9@gmail.com \
--to=dsahern@gmail.com \
--cc=girish.moodalbail@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).