From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 5/7] net: phy: smss: prepare for making edpd wait period configurable
Date: Sun, 2 Apr 2023 11:47:03 +0200 [thread overview]
Message-ID: <602fd4ec-3448-d45b-034a-6110a4a454d6@gmail.com> (raw)
In-Reply-To: <17fcccf5-8d81-298e-0671-d543340da105@gmail.com>
Add a member edpd_max_wait_ms to the private data structure in preparation
of making the wait period configurable by supporting the edpd phy tunable.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/smsc.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index 25b9cd474..0cd433f01 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -33,6 +33,8 @@
#define SPECIAL_CTRL_STS_AMDIX_ENABLE_ 0x4000
#define SPECIAL_CTRL_STS_AMDIX_STATE_ 0x2000
+#define EDPD_MAX_WAIT_DFLT 640
+
struct smsc_hw_stat {
const char *string;
u8 reg;
@@ -46,6 +48,7 @@ static struct smsc_hw_stat smsc_hw_stats[] = {
struct smsc_phy_priv {
unsigned int edpd_enable:1;
unsigned int edpd_mode_set_by_user:1;
+ unsigned int edpd_max_wait_ms;
};
static int smsc_phy_ack_interrupt(struct phy_device *phydev)
@@ -213,9 +216,13 @@ int lan87xx_read_status(struct phy_device *phydev)
if (err)
return err;
- if (!phydev->link && priv && priv->edpd_enable) {
+ if (!phydev->link && priv && priv->edpd_enable &&
+ priv->edpd_max_wait_ms) {
+ unsigned int max_wait = priv->edpd_max_wait_ms * 1000;
+ int rc;
+
/* Disable EDPD to wake up PHY */
- int rc = phy_read(phydev, MII_LAN83C185_CTRL_STATUS);
+ rc = phy_read(phydev, MII_LAN83C185_CTRL_STATUS);
if (rc < 0)
return rc;
@@ -229,7 +236,7 @@ int lan87xx_read_status(struct phy_device *phydev)
*/
read_poll_timeout(phy_read, rc,
rc & MII_LAN83C185_ENERGYON || rc < 0,
- 10000, 640000, true, phydev,
+ 10000, max_wait, true, phydev,
MII_LAN83C185_CTRL_STATUS);
if (rc < 0)
return rc;
@@ -299,6 +306,7 @@ int smsc_phy_probe(struct phy_device *phydev)
return -ENOMEM;
priv->edpd_enable = true;
+ priv->edpd_max_wait_ms = EDPD_MAX_WAIT_DFLT;
if (device_property_present(dev, "smsc,disable-energy-detect"))
priv->edpd_enable = false;
--
2.40.0
next prev parent reply other threads:[~2023-04-02 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 9:43 [PATCH net-next 0/7] net: phy: smsc: add support for edpd tunable Heiner Kallweit
2023-04-02 9:44 ` [PATCH net-next 1/7] net: phy: smsc: rename flag energy_enable Heiner Kallweit
2023-04-02 9:45 ` [PATCH net-next 2/7] net: phy: smsc: add helper smsc_phy_config_edpd Heiner Kallweit
2023-04-02 9:45 ` [PATCH net-next 3/7] net: phy: smsc: clear edpd_enable if interrupt mode is used Heiner Kallweit
2023-04-02 9:46 ` [PATCH net-next 4/7] net: phy: smsc: add flag edpd_mode_set_by_user Heiner Kallweit
2023-04-02 9:47 ` Heiner Kallweit [this message]
2023-04-02 9:47 ` [PATCH net-next 6/7] net: phy: smsc: add edpd tunable support Heiner Kallweit
2023-04-02 12:08 ` Simon Horman
2023-04-02 13:52 ` Heiner Kallweit
2023-04-02 9:48 ` [PATCH net-next 7/7] net: phy: smsc: enable " Heiner Kallweit
2023-04-02 14:00 ` [PATCH net-next 0/7] net: phy: smsc: add support for edpd tunable Florian Fainelli
2023-04-02 14:58 ` Heiner Kallweit
2023-04-02 23:33 ` Chris Healy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=602fd4ec-3448-d45b-034a-6110a4a454d6@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).