From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:40164 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934133AbeCBH54 (ORCPT ); Fri, 2 Mar 2018 02:57:56 -0500 Received: by mail-lf0-f67.google.com with SMTP id 37so12101933lfs.7 for ; Thu, 01 Mar 2018 23:57:55 -0800 (PST) Subject: Re: [PATCH iproute2 2/3] ss: Fix build with old libc headers without AF_VSOCK To: Stephen Hemminger Cc: netdev@vger.kernel.org, thomas.de_schampheleire@nokia.com References: <1519733212-30703-1-git-send-email-serhe.popovych@gmail.com> <1519733212-30703-3-git-send-email-serhe.popovych@gmail.com> <20180228161328.3067263b@xeon-e3> From: Serhey Popovych Message-ID: <60388182-c6fd-6583-e37b-089b004a3ff9@gmail.com> Date: Fri, 2 Mar 2018 09:57:52 +0200 MIME-Version: 1.0 In-Reply-To: <20180228161328.3067263b@xeon-e3> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tEw4lpDBSOY9kPHGhllEEnwvzqb4gWu2H" Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tEw4lpDBSOY9kPHGhllEEnwvzqb4gWu2H Content-Type: multipart/mixed; boundary="6cis2Vz0WlC29BPRsFUVmdRl3QWIEU3cm"; protected-headers="v1" From: Serhey Popovych To: Stephen Hemminger Cc: netdev@vger.kernel.org, thomas.de_schampheleire@nokia.com Message-ID: <60388182-c6fd-6583-e37b-089b004a3ff9@gmail.com> Subject: Re: [PATCH iproute2 2/3] ss: Fix build with old libc headers without AF_VSOCK References: <1519733212-30703-1-git-send-email-serhe.popovych@gmail.com> <1519733212-30703-3-git-send-email-serhe.popovych@gmail.com> <20180228161328.3067263b@xeon-e3> In-Reply-To: <20180228161328.3067263b@xeon-e3> --6cis2Vz0WlC29BPRsFUVmdRl3QWIEU3cm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Stephen Hemminger wrote: > On Tue, 27 Feb 2018 14:06:51 +0200 > Serhey Popovych wrote: >=20 >> diff --git a/include/compat/libc/bits/socket.h b/include/compat/libc/b= its/socket.h >> new file mode 100644 >> index 0000000..25ef0d5 >> --- /dev/null >> +++ b/include/compat/libc/bits/socket.h >> @@ -0,0 +1,15 @@ >> +#ifndef _IP_COMPAT_BITS_SOCKET_H >> +#define _IP_COMPAT_BITS_SOCKET_H >> + >> +#include_next >> + >> +#ifndef AF_VSOCK >> +#define PF_VSOCK 40 >> +#define AF_VSOCK PF_VSOCK >> +#undef PF_MAX >> +#undef AF_MAX >> +#define PF_MAX 41 >> +#define AF_MAX PF_MAX >> +#endif /* AF_VSOCK */ >> + >> +#endif /* _IP_COMPAT_BITS_SOCKET_H */ >=20 > It makes more sense to change ss.c to ifdef out the code related to AF_= VSOCK > if it is not defined. Rather than asking for unknown address family. >=20 Yes, I did this as v0 before sending series. But now I'm thinking that single place for all compat stuff would ease tracking of changes. --6cis2Vz0WlC29BPRsFUVmdRl3QWIEU3cm-- --tEw4lpDBSOY9kPHGhllEEnwvzqb4gWu2H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJamQQBAAoJEBTawMmQ61bBBNwH/25ria7ySBIcBPSGImdAtqo/ nXKyF5QhrI2/apWkD6/S4bPJy31Pp2yYcEmYWP2Ygn6UOK32Dv+zbYUpzY6aKF6v c7G7IMEMDbpFozoF45GOVYk2InNvv2kzDqvcXGuGQh+oFvrh/w0jbFDv9ZUCXijX 3HJxgoH9zva2/G6M6Plc51//LlJXM1vJs97YbiEnMgSjDfHCzZWdc3sy3j027ZGM 4PITn3vc0Kn83UtxqPJy3Oq3wEyK9NMDEQYEPwI+oJNVQ6V4nc3H9DgywfqlsS5M wtpsIUiclUTAaT/U8gndqG6cE6Ph2r2+TFjl7ssERDY7ZA6QWkLS7k31zKT28EI= =kn/O -----END PGP SIGNATURE----- --tEw4lpDBSOY9kPHGhllEEnwvzqb4gWu2H--