From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646BE21770C for ; Tue, 4 Feb 2025 18:32:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738693956; cv=none; b=tkSCV27TT6w5r/quNKJDGoSD9GZLgNT8D2JX4+tQibvUbgAIXcaHrgK4qD/mdMlnmfBEfhP/ELLfCEKIC9BqLovR0CkFbZgqFnucdATnw6pHaBLJjLuAoN6DcgQPU6/J7EHsFHgS/WVzv9dl94TQdGz866zQgutdDaA3LCO1WmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738693956; c=relaxed/simple; bh=xODQit6uCyf4BHOUHzlpnmvPH+m6KEWI7kEV2tYKTKA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hIb8eKOJk8NMlxRFFcZHKWvEuCUcmxFXzEMf6DSnNelQydWnf6de34shRrRjJvZFn/kfQkpfCET9D6qELey/dCOkDSmCY9RlO/zVzYjOl9jw/LSyorIc3puOOl/bVAlk+BRXLAGS4m82WQl4Su276UI8r0guyHJWaaWHD0H5aVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OTpmoKMI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OTpmoKMI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738693953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/wOAl5xAh2GGBxVsErS9v9Tjb+O3mJNAwDX/dH5vXFY=; b=OTpmoKMIol1+ywmE50EZtdpNWexEiW45iv8qw38uvG1IqOsBq7AbkK+S6kxyF9YPDn909U GT1UCjWVEj34kyRiat9qTBXsW5pCvoc9tCdyRdA8tKb5BoLvJlPuILajmPeRou+5pG7YCA W4+a394pbdHjhNws/L3B5ULKhGAnp8k= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-Rf6zfTmeNGS1I9HfcUG6lQ-1; Tue, 04 Feb 2025 13:32:32 -0500 X-MC-Unique: Rf6zfTmeNGS1I9HfcUG6lQ-1 X-Mimecast-MFC-AGG-ID: Rf6zfTmeNGS1I9HfcUG6lQ Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38c5dcb33a5so3913805f8f.2 for ; Tue, 04 Feb 2025 10:32:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738693951; x=1739298751; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/wOAl5xAh2GGBxVsErS9v9Tjb+O3mJNAwDX/dH5vXFY=; b=PkTWiEHk5HkTxPqWt2dYeU+yMEOxkU0w/9ewhdKjfZWf5lneYbIiV2CRckyvFLptqo K5mnXslwUIi3/TX0y6x1RM0Q5m3Ku+8kn+nT4y67zEqDSTqDUnSUi502tC2Bd4hlfdPd hq2vIgHxRLnYnBjW/A1zNrtCC0YZol8LR2wx9Zy4SHwmFuWTU4okOGJknpdcBz54cWz/ UgVxCKUrdrkDwxbNYyTUmNjlblyvc9jk9tgr1GyqZj1sSDCuqJQV+9J1TqXoxsfQsUpg pdjWv8tjVobiKyi6rB77Vupi/CWlA6nvlcfQjHxtMH1m3KyP4UxvpsUO3o664W/T6V4M aJvA== X-Gm-Message-State: AOJu0Yw9uAL6SxyvnHe+YqRZtgCXSEjq+n4qH2y5OK5tsmemgSHrMl2E RL9HVZIC1TCX2WbD4DpZ8DiUUjtWxwD9vy//HYd+DTWqBc5wrgrUp+PDrs+plqqOhDNEVskIvl8 iFvH5kmwXdYn2M9MDnHnpNhbPLrcxHVDIVUwjLsxBqP6Y4Tfg3JGllA== X-Gm-Gg: ASbGncs3OEpnPfp0gFQRDW+zjcbtDREwisM/FkXSaW4OxNOruBIgaOlosJLdlWCgK4M Dtml06yD0bGLzD9ATQeiM6v0GrEj+xIA/IYDCIe8VqrYmPC5I0bwVs0YEebwnWpl+VAHVioIqTw 1MqH00LxD7NO8HV2YbPL5JUOK+YXbYoP3bXSIGzOUW0v+fNnkzIfET4YqKVrXKlBFTWQW9s8fUW EEyxiwVAac7w8GRxKYmlbEc3Gh/vTTj9geRf3uW4wx4zpzdTwsveJeh0nYJNuYyfbEgMKAUooVO XR3IGIqDEa+oM7Wc9Ta1Jtk+HR6g3rGUnk4= X-Received: by 2002:a5d:584e:0:b0:38a:8b00:6908 with SMTP id ffacd0b85a97d-38c520b0b23mr23613458f8f.54.1738693950891; Tue, 04 Feb 2025 10:32:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFD/Vu5xJexoTki9KN1frdyawMdJlGIYRVOCgdaZ1pwR1o9hVUkrti8bPAifEmhLPHuA8ZQBg== X-Received: by 2002:a5d:584e:0:b0:38a:8b00:6908 with SMTP id ffacd0b85a97d-38c520b0b23mr23613436f8f.54.1738693950460; Tue, 04 Feb 2025 10:32:30 -0800 (PST) Received: from [192.168.88.253] (146-241-41-201.dyn.eolo.it. [146.241.41.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c12247esm17079089f8f.53.2025.02.04.10.32.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 10:32:29 -0800 (PST) Message-ID: <60550f27-ea6a-4165-8eaa-a730d02a5ddc@redhat.com> Date: Tue, 4 Feb 2025 19:32:27 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 0/6] Device memory TCP TX To: Stanislav Fomichev , Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kselftest@vger.kernel.org, Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , Jonathan Corbet , Andrew Lunn , Neal Cardwell , David Ahern , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Stefan Hajnoczi , Stefano Garzarella , Shuah Khan , sdf@fomichev.me, asml.silence@gmail.com, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja References: <20250203223916.1064540-1-almasrymina@google.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/4/25 7:06 PM, Stanislav Fomichev wrote: > On 02/04, Mina Almasry wrote: >> On Tue, Feb 4, 2025 at 4:32 AM Paolo Abeni wrote: >>> >>> On 2/3/25 11:39 PM, Mina Almasry wrote: >>>> The TX path had been dropped from the Device Memory TCP patch series >>>> post RFCv1 [1], to make that series slightly easier to review. This >>>> series rebases the implementation of the TX path on top of the >>>> net_iov/netmem framework agreed upon and merged. The motivation for >>>> the feature is thoroughly described in the docs & cover letter of the >>>> original proposal, so I don't repeat the lengthy descriptions here, but >>>> they are available in [1]. >>>> >>>> Sending this series as RFC as the winder closure is immenient. I plan on >>>> reposting as non-RFC once the tree re-opens, addressing any feedback >>>> I receive in the meantime. >>> >>> I guess you should drop this paragraph. >>> >>>> Full outline on usage of the TX path is detailed in the documentation >>>> added in the first patch. >>>> >>>> Test example is available via the kselftest included in the series as well. >>>> >>>> The series is relatively small, as the TX path for this feature largely >>>> piggybacks on the existing MSG_ZEROCOPY implementation. >>> >>> It looks like no additional device level support is required. That is >>> IMHO so good up to suspicious level :) >>> >> >> It is correct no additional device level support is required. I don't >> have any local changes to my driver to make this work. I think Stan >> on-list was able to run the TX path (he commented on fixes to the test >> but didn't say it doesn't work :D) and one other person was able to >> run it offlist. > > For BRCM I had shared this: https://lore.kernel.org/netdev/ZxAfWHk3aRWl-F31@mini-arch/ > I have similar internal patch for mlx5 (will share after RX part gets > in). I agree that it seems like gve_unmap_packet needs some work to be more > careful to not unmap NIOVs (if you were testing against gve). What happen if an user try to use devmem TX on a device not really supporting it? Silent data corruption? Don't we need some way for the device to opt-in (or opt-out) and avoid such issues? /P