From: Chenbo Feng <chenbofeng.kernel@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Lorenzo Colitti <lorenzo@google.com>,
Eric Dumazet <edumazet@google.com>,
Chenbo Feng <fengc@google.com>
Subject: Re: [PATCH net-next] Revert "ipv6: Initial skb->dev and skb->protocol in ip6_output"
Date: Sat, 10 Jun 2017 12:36:32 -0700 [thread overview]
Message-ID: <606f7dc5-95c1-134d-60ef-d296c2922df5@gmail.com> (raw)
In-Reply-To: <1497106547.736.104.camel@edumazet-glaptop3.roam.corp.google.com>
On 06/10/2017 07:55 AM, Eric Dumazet wrote:
> On Fri, 2017-06-09 at 12:56 -0700, Chenbo Feng wrote:
>> From: Chenbo Feng <fengc@google.com>
>>
>> This reverts commit 97a7a37a7b7b("ipv6: Initial skb->dev and
>> skb->protocol in ip6_output") since it does not handles the
>> skb->dev assignment inside ip6_fragment() code path properly.
>> Need to rework and upload again
> We can avoid the revert I believe the patch is fine after analysis.
>
> Please submit this followup, thanks ! :
>
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index 02cd44f0953900108701895108b2fdaa9f9980e5..0d6f3b6345de26c329ae1d6f25dde652a5452d4b 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -869,7 +869,6 @@ int ip6_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
> if (skb->sk && dst_allfrag(skb_dst(skb)))
> sk_nocaps_add(skb->sk, NETIF_F_GSO_MASK);
>
> - skb->dev = skb_dst(skb)->dev;
> icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);
> err = -EMSGSIZE;
>
>
>
>
Thanks for the help! Patch submitted here:
http://patchwork.ozlabs.org/patch/774260/
prev parent reply other threads:[~2017-06-10 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 19:56 [PATCH net-next] Revert "ipv6: Initial skb->dev and skb->protocol in ip6_output" Chenbo Feng
2017-06-10 14:55 ` Eric Dumazet
2017-06-10 19:36 ` Chenbo Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=606f7dc5-95c1-134d-60ef-d296c2922df5@gmail.com \
--to=chenbofeng.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fengc@google.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).