From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v2 net-next] tcp: expose sk_state in tcp_retransmit_skb tracepoint Date: Tue, 25 Sep 2018 19:47:01 -0700 Message-ID: <6074980f-5c7d-d427-bf3e-f5b6e7d6500b@gmail.com> References: <1537793849-32396-1-git-send-email-laoar.shao@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Yafang Shao , edumazet@google.com, davem@davemloft.net Return-path: Received: from mail-pf1-f196.google.com ([209.85.210.196]:44388 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbeIZI5l (ORCPT ); Wed, 26 Sep 2018 04:57:41 -0400 Received: by mail-pf1-f196.google.com with SMTP id k21-v6so12552713pff.11 for ; Tue, 25 Sep 2018 19:47:03 -0700 (PDT) In-Reply-To: <1537793849-32396-1-git-send-email-laoar.shao@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/24/2018 05:57 AM, Yafang Shao wrote: > After sk_state exposed, we can get in which state this retransmission > occurs. That could give us more detail for dignostic. > For example, if this retransmission occurs in SYN_SENT state, it may > also indicates that the syn packet may be dropped on the remote peer due > to syn backlog queue full and then we could check the remote peer. > > BTW,SYNACK retransmission is traced in tcp_retransmit_synack tracepoint. > > Signed-off-by: Yafang Shao Signed-off-by: Eric Dumazet