From: Nikolai Zhubr <zhubr.2@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Chris Snook <chris.snook@gmail.com>, netdev@vger.kernel.org
Subject: Re: A problem with "ip=..." ipconfig and Atheros alx driver.
Date: Fri, 30 Apr 2021 20:15:24 +0300 [thread overview]
Message-ID: <608C3B2C.8040005@gmail.com> (raw)
In-Reply-To: <419eea59adc7af954f98ac81ec41a7be9cc0d9bb.camel@sipsolutions.net>
Hi Johannes,
30.04.2021 15:08, Johannes Berg:
>> rtnl_unlock(). Hence this delay and timeout.
>
> Fun. But we can just do it synchronously?
>
> https://p.sipsolutions.net/e4f076ed1b4c8a78.txt
Wow, that was quick! Thanks! However, unfortunately this patch still
does not quite fix the problem. Although alx_check_link() now gets
called synchronously at open, it somehow does not pass below the "if
(old_speed == hw->link_speed) return" line here. I'd guess it is because
the chip is not yet able to report meaningfull values immediately after
initialization. The result is still the same: 120 seconds timeout
happens, then the "eth0: NIC Up: 1 Gbps Full" message appears
immediately and all is fine after that.
I'll do some more testing later today.
Thank you,
Regards,
Nikolai
>
> johannes
>
>
next prev parent reply other threads:[~2021-04-30 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 11:59 A problem with "ip=..." ipconfig and Atheros alx driver Nikolai Zhubr
2021-04-30 12:08 ` Johannes Berg
2021-04-30 17:15 ` Nikolai Zhubr [this message]
2021-04-30 19:02 ` Johannes Berg
2021-05-01 0:01 ` Nikolai Zhubr
2021-05-01 13:50 ` Nikolai Zhubr
2021-05-02 9:04 ` Johannes Berg
2021-05-02 10:28 ` Nikolai Zhubr
2021-05-02 11:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=608C3B2C.8040005@gmail.com \
--to=zhubr.2@gmail.com \
--cc=chris.snook@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).