From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [PATCH net-next] net: fib_rules: fix l3mdev netlink attr
 processing
Date: Mon, 23 Apr 2018 21:43:27 -0600
Message-ID: <60931ebf-d72f-564e-b296-878454f4880a@cumulusnetworks.com>
References: <1524539321-9103-1-git-send-email-roopa@cumulusnetworks.com>
 <20180423.232158.1633374650832506893.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: David Miller <davem@davemloft.net>, roopa@cumulusnetworks.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f48.google.com ([74.125.83.48]:38407 "EHLO
        mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932780AbeDXDn3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 23 Apr 2018 23:43:29 -0400
Received: by mail-pg0-f48.google.com with SMTP id b5so9824114pgv.5
        for <netdev@vger.kernel.org>; Mon, 23 Apr 2018 20:43:29 -0700 (PDT)
In-Reply-To: <20180423.232158.1633374650832506893.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 4/23/18 9:21 PM, David Miller wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Mon, 23 Apr 2018 20:08:41 -0700
> 
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> Fixes: b16fb418b1bf ("net: fib_rules: add extack support")
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> Applied.
> 
> It would be nice to get rid of these if() conditionals dangling
> around ifdef blocks.  They are quite error prone.
> 

I'll send a patch. I'd prefer a different message when NET_L3_MASTER_DEV
is not enabled.