From: John Fastabend <john.fastabend@gmail.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>,
"Magnus Karlsson" <magnus.karlsson@gmail.com>
Cc: "Karlsson, Magnus" <magnus.karlsson@intel.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Netdev <netdev@vger.kernel.org>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
bpf <bpf@vger.kernel.org>, Dan Siemon <dan@coverfire.com>
Subject: Re: [PATCH bpf-next] xsk: use kvcalloc to support large umems
Date: Mon, 24 May 2021 10:59:12 -0700 [thread overview]
Message-ID: <60abe97091b07_135f62089f@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <CAJ+HfNjBwNjGwuT1jkkPO+n06GFnN4yornYpxb3M9MNg7+EYgg@mail.gmail.com>
Björn Töpel wrote:
> On Fri, 21 May 2021 at 10:33, Magnus Karlsson <magnus.karlsson@gmail.com> wrote:
> >
> > From: Magnus Karlsson <magnus.karlsson@intel.com>
> >
> > Use kvcalloc() instead of kcalloc() to support large umems with, on my
> > server, one million pages or more in the umem.
> >
> > Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
> > Reported-by: Dan Siemon <dan@coverfire.com>
>
> Nice!
>
> Acked-by: Björn Töpel <bjorn@kernel.org>
LGTM as well. I scanned the driver side, thinking there might be
some complication there, but looks like it handles this fine.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2021-05-24 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 8:33 [PATCH bpf-next] xsk: use kvcalloc to support large umems Magnus Karlsson
2021-05-22 14:12 ` Björn Töpel
2021-05-24 17:59 ` John Fastabend [this message]
2021-05-25 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60abe97091b07_135f62089f@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=dan@coverfire.com \
--cc=daniel@iogearbox.net \
--cc=jonathan.lemon@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).