From: Saeed Mahameed <saeed@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [pull request][net 00/12] mlx5 fixes 2021-01-26
Date: Wed, 27 Jan 2021 15:08:33 -0800 [thread overview]
Message-ID: <60b15846db82c2ff50bcb90aa2646d5baf9247b8.camel@kernel.org> (raw)
In-Reply-To: <CAF=yD-+85F+9Mzosv3+7WKKUk5r5GM+nRthCQx0UX4ux0LMCsQ@mail.gmail.com>
On Wed, 2021-01-27 at 15:03 -0500, Willem de Bruijn wrote:
> On Wed, Jan 27, 2021 at 2:36 AM Saeed Mahameed <saeedm@nvidia.com>
> wrote:
> >
> > Hi Jakub, Dave
> >
> > This series introduces some fixes to mlx5 driver.
> > Please pull and let me know if there is any problem.
> >
> > Thanks,
> > Saeed.
> >
> > ---
> > The following changes since commit
> > c5e9e8d48acdf3b863282af7f6f6931d39526245:
> >
> > Merge tag 'mac80211-for-net-2021-01-26' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211 (2021-
> > 01-26 15:23:18 -0800)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git
> > tags/mlx5-fixes-2021-01-26
> >
> > for you to fetch changes up to
> > e2194a1744e8594e82a861687808c1adca419b85:
> >
> > net/mlx5: CT: Fix incorrect removal of tuple_nat_node from nat
> > rhashtable (2021-01-26 15:39:04 -0800)
> >
> > ----------------------------------------------------------------
> > mlx5-fixes-2021-01-26
> >
> > ----------------------------------------------------------------
> > Daniel Jurgens (1):
> > net/mlx5: Maintain separate page trees for ECPF and PF
> > functions
> >
> > Maor Dickman (2):
> > net/mlx5e: Reduce tc unsupported key print level
> > net/mlx5e: Disable hw-tc-offload when MLX5_CLS_ACT config is
> > disabled
> >
> > Maxim Mikityanskiy (4):
> > net/mlx5e: Fix IPSEC stats
> > net/mlx5e: Correctly handle changing the number of queues
> > when the interface is down
> > net/mlx5e: Revert parameters on errors when changing trust
> > state without reset
> > net/mlx5e: Revert parameters on errors when changing MTU and
> > LRO state without reset
> >
> > Pan Bian (1):
> > net/mlx5e: free page before return
> >
> > Parav Pandit (1):
> > net/mlx5e: E-switch, Fix rate calculation for overflow
> >
> > Paul Blakey (2):
> > net/mlx5e: Fix CT rule + encap slow path offload and deletion
> > net/mlx5: CT: Fix incorrect removal of tuple_nat_node from
> > nat rhashtable
> >
> > Roi Dayan (1):
> > net/mlx5: Fix memory leak on flow table creation error flow
> >
> > .../net/ethernet/mellanox/mlx5/core/en/health.c | 2 +-
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 20 +++++---
> > .../mellanox/mlx5/core/en_accel/ipsec_stats.c | 4 +-
> > drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 13 +++--
> > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 8 ++-
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 39
> > +++++++++++----
> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +
> > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 22 ++++++--
> > drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 1 +
> > .../net/ethernet/mellanox/mlx5/core/pagealloc.c | 58
> > +++++++++++++---------
> > 10 files changed, 114 insertions(+), 55 deletions(-)
>
> For netdrv:
>
> Acked-by: Willem de Bruijn <willemb@google.com>
>
> I left a small comment in patch 11/12, but no need to change that.
>
> In patch 12/12, the removal of branch if (entry->tuple_node.next) is
> not entirely obvious to me, but based on the commit message I assume
> that it was intentional. Pointing it out only in the unlikely case
> that it wasn't.
it was intentional as the check was redundant.
Thanks for the review!
prev parent reply other threads:[~2021-01-27 23:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 23:43 [pull request][net 00/12] mlx5 fixes 2021-01-26 Saeed Mahameed
2021-01-26 23:43 ` [net 01/12] net/mlx5: Fix memory leak on flow table creation error flow Saeed Mahameed
2021-01-28 3:30 ` patchwork-bot+netdevbpf
2021-01-28 8:33 ` Saeed Mahameed
2021-01-29 1:37 ` Jakub Kicinski
2021-01-26 23:43 ` [net 02/12] net/mlx5e: E-switch, Fix rate calculation for overflow Saeed Mahameed
2021-01-26 23:43 ` [net 03/12] net/mlx5e: free page before return Saeed Mahameed
2021-01-26 23:43 ` [net 04/12] net/mlx5e: Reduce tc unsupported key print level Saeed Mahameed
2021-01-26 23:43 ` [net 05/12] net/mlx5e: Fix IPSEC stats Saeed Mahameed
2021-01-26 23:43 ` [net 06/12] net/mlx5: Maintain separate page trees for ECPF and PF functions Saeed Mahameed
2021-01-26 23:43 ` [net 07/12] net/mlx5e: Disable hw-tc-offload when MLX5_CLS_ACT config is disabled Saeed Mahameed
2021-01-26 23:43 ` [net 08/12] net/mlx5e: Fix CT rule + encap slow path offload and deletion Saeed Mahameed
2021-01-26 23:43 ` [net 09/12] net/mlx5e: Correctly handle changing the number of queues when the interface is down Saeed Mahameed
2021-01-26 23:43 ` [net 10/12] net/mlx5e: Revert parameters on errors when changing trust state without reset Saeed Mahameed
2021-01-26 23:43 ` [net 11/12] net/mlx5e: Revert parameters on errors when changing MTU and LRO " Saeed Mahameed
2021-01-27 20:00 ` Willem de Bruijn
2021-01-27 23:06 ` Saeed Mahameed
2021-01-26 23:43 ` [net 12/12] net/mlx5: CT: Fix incorrect removal of tuple_nat_node from nat rhashtable Saeed Mahameed
2021-01-27 20:03 ` [pull request][net 00/12] mlx5 fixes 2021-01-26 Willem de Bruijn
2021-01-27 23:08 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60b15846db82c2ff50bcb90aa2646d5baf9247b8.camel@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).