netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>,
	"Lorenzo Colitti" <lorenzo@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Linux NetDev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net-ipv6: fix excessive RTF_ADDRCONF flag on ::1/128 local route (and others)
Date: Tue, 3 Sep 2019 13:45:53 -0600	[thread overview]
Message-ID: <60b98521-cf3a-1130-896d-2947fc4d5290@gmail.com> (raw)
In-Reply-To: <CAHo-OoyQzJptNDcLe93o3-G10oRN+93ZZ35jKkLudSanvgn-2Q@mail.gmail.com>

On 9/3/19 6:17 AM, Maciej Żenczykowski wrote:
> Well, if you look at the commit my commit is fixing, ie.
>   commit c7a1ce397adacaf5d4bb2eab0a738b5f80dc3e43
> then you'll see this in the commit description:
>   "- dst_nocount is handled by the RTF_ADDRCONF flag"
> and the patch diff itself is from
>   "f6i->fib6_flags = RTF_UP | RTF_NONEXTHOP;
>    f6i->dst_nocount = true;"
> to
>   " .fc_flags = RTF_UP | RTF_ADDRCONF | RTF_NONEXTHOP,"
> 
> (and RTF_ANYCAST or RTF_LOCAL is later or'ed in in both versions of the code)
> 
> so I'm pretty sure that patch adds ADDRCONF unconditionally to that
> function, and my commit unconditionally removes it.
> 

exactly. It was shortsighted of me to add the ADDRCONF flag and removing
it reverts back to the previous behavior.

When I enable radvd, I do see the flag set when it should be and not for
other addresses. I believe the patch is correct.


  reply	other threads:[~2019-09-03 19:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-01 17:47 [PATCH] net-ipv6: fix excessive RTF_ADDRCONF flag on ::1/128 local route (and others) Maciej Żenczykowski
2019-09-01 17:55 ` Maciej Żenczykowski
2019-09-02  2:12   ` Lorenzo Colitti
2019-09-03  2:18     ` David Ahern
2019-09-03  4:58       ` Lorenzo Colitti
2019-09-03 12:17         ` Maciej Żenczykowski
2019-09-03 19:45           ` David Ahern [this message]
2019-09-04  3:17             ` Lorenzo Colitti
2019-09-02 13:37 ` David Ahern
2019-09-02 16:23   ` [PATCH v2] " Maciej Żenczykowski
2019-09-03  2:14     ` David Ahern
2019-09-04 22:33     ` David Miller
2019-09-05 18:49     ` Eric Dumazet
2019-09-06  3:31       ` Maciej Żenczykowski
2019-09-06  3:56         ` [PATCH] net-ipv6: addrconf_f6i_alloc - fix non-null pointer check to !IS_ERR() Maciej Żenczykowski
2019-09-06  5:10           ` Eric Dumazet
2019-09-07 15:48           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60b98521-cf3a-1130-896d-2947fc4d5290@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=zenczykowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).