Re: [PATCH v2 net-next 3/4] selftests: xsk: move the AF_XDP test suite to selftests/net

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi,

On 11/9/26 20:30, Maciej Fijalkowski wrote:
> Move the xskxceiver engine, the AF_XDP userspace library, the test
> definitions and the XDP program to net/lib/xsk, and test_xsk.sh with
> xsk_prereqs.sh to selftests/net.
> 
> net/lib builds the XDP program and its skeleton with the bpf.mk rules,
> and skips xskxceiver with a warning when bpftool does not work, in
> which case test_xsk.sh skips too. List test_xsk.sh in
> TEST_PROGS_EXTENDED, so that it is installed but NIPA does not run it
> yet: it runs every case, flaky ones included.
> 
> xskxceiver builds against the uapi headers from make headers, whose
> linux/netlink.h does not pull in linux/kernel.h, so include it for
> min_t() directly. Put tools/include ahead of CFLAGS, so that in O=
> builds a stale usr/include in the source tree does not shadow its
> linux/kernel.h and linux/types.h. Move the ethtool ring helpers from
> network_helpers into xsk.c, and cast to void * in the bound check of
> the XDP program, as bpf.mk does not build with
> -Wno-compare-distinct-pointer-types.
> 
> xdp_hw_metadata and the xdp_metadata test keep using xsk.c from
> net/lib/xsk: selftests/bpf builds xsk.o from there in place of the
> find_bit.o rule, which only test_xsk.c needed. Update MAINTAINERS.
> 
> Reviewed-by: Björn Töpel <bjorn@kernel.org>
> Acked-by: Stanislav Fomichev <sdf@fomichev.me>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

This patch fails to cross-compile when using RiscV as a target, cf
the output in :

https://netdevci.bootlin.com/stmmac/outputs/905943-bootlin-stmmac-motorcomm/build

I'm not quite sure this is an infra problem on my end, any chance you can
look this up ?

looks like it fails to include <asm/fence.h>

Maxime