From: Serhey Popovych <serhe.popovych@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] loopback: Force LOOPBACK_IFINDEX for registration
Date: Tue, 20 Jun 2017 13:32:20 +0300 [thread overview]
Message-ID: <60e546b5-2548-5eef-ebc6-4cf0ca44da27@gmail.com> (raw)
In-Reply-To: <20170619.144123.2070662074449196481.davem@davemloft.net>
> From: Serhey Popovych <serhe.popovych@gmail.com>
> Date: Fri, 16 Jun 2017 15:10:03 +0300
>
>> Now with commit 9c7dafb (net: Allow to create links with
>> given ifindex) support registration of network devices
>> with specific ifindex is added.
>>
>> We can force loopback network device index before call to
>> register_netdev() to ensure we always configure it with
>> LOOPBACK_IFINDEX.
>>
>> Kill BUG_ON() since system can continue without network
>> namespace failed in loopback init path, unless it is
>> init_net namespace where we panic() anyway.
>>
>> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
>
> Is the BUG_ON() triggering, if so why?
>
> It looks to me that unless there is a bug, this assignment
> is unnecessary.
>
Okay, get your position, thanks!
--
Thanks, Serhey
next prev parent reply other threads:[~2017-06-20 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 12:10 [PATCH] loopback: Force LOOPBACK_IFINDEX for registration Serhey Popovych
2017-06-17 11:21 ` Sergei Shtylyov
2017-06-19 18:41 ` David Miller
2017-06-20 10:32 ` Serhey Popovych [this message]
2017-06-21 9:35 ` Serhey Popovych
2017-06-21 15:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e546b5-2548-5eef-ebc6-4cf0ca44da27@gmail.com \
--to=serhe.popovych@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).