From: John Fastabend <john.fastabend@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>,
John Fastabend <john.fastabend@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on unlikely error case
Date: Thu, 08 Jul 2021 13:39:04 -0700 [thread overview]
Message-ID: <60e76268e64fc_653a42085b@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <CAM_iQpWXDY=YeNS_Kn6eWZc-0MHF3Cr0fwFzGESYvtOJt0eD0A@mail.gmail.com>
Cong Wang wrote:
> On Tue, Jul 6, 2021 at 9:31 AM John Fastabend <john.fastabend@gmail.com> wrote:
> >
> > If skb_linearize is needed and fails we could leak a msg on the error
> > handling. To fix ensure we kfree the msg block before returning error.
> > Found during code review.
>
> sk_psock_skb_ingress_self() also needs the same fix, right?
Yep.
> Other than this, it looks good to me.
I'll do another spin to get the other one as well. Mind as well
fix both cases at once.
>
> Thanks.
next prev parent reply other threads:[~2021-07-08 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 16:31 [PATCH bpf v3 0/2] potential sockmap memleak and proc stats fix John Fastabend
2021-07-06 16:31 ` [PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on unlikely error case John Fastabend
2021-07-08 19:38 ` Cong Wang
2021-07-08 20:39 ` John Fastabend [this message]
2021-07-06 16:31 ` [PATCH bpf v3 2/2] bpf, sockmap: sk_prot needs inuse_idx set for proc stats John Fastabend
2021-07-08 19:42 ` Cong Wang
2021-07-12 7:22 ` Jakub Sitnicki
2021-07-12 17:17 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e76268e64fc_653a42085b@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).