netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Liang <xiliang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: jgross@suse.com, netdev@vger.kernel.org,
	boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH] xen-netfront: wait xenbus state change when load module manually
Date: Mon, 30 Jul 2018 16:18:10 +0800	[thread overview]
Message-ID: <60e93e09-7dc2-d2f6-379d-c1d086aa1f49@redhat.com> (raw)
In-Reply-To: <20180729.083040.53901922165497594.davem@davemloft.net>

Thanks, David

On 07/29/2018 11:30 PM, David Miller wrote:
> From: Xiao Liang <xiliang@redhat.com>
> Date: Fri, 27 Jul 2018 17:56:08 +0800
>
>> @@ -1330,6 +1331,11 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev)
>>   	netif_carrier_off(netdev);
>>   
>>   	xenbus_switch_state(dev, XenbusStateInitialising);
>> +	wait_event(module_load_q,
>> +			   xenbus_read_driver_state(dev->otherend) !=
>> +			   XenbusStateClosed &&
>> +			   xenbus_read_driver_state(dev->otherend) !=
>> +			   XenbusStateUnknown);
>>   	return netdev;
>>   
>>    exit:
> What performs the wakeups that will trigger for this sleep site?
In my understanding, backend leaving closed/unknow state can trigger the 
wakeups. I mean to make sure both sides are ready for creating connection.

Thanks,
Liang
>
> Thank you.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-07-30  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  9:56 [PATCH] xen-netfront: wait xenbus state change when load module manually Xiao Liang
2018-07-27 18:40 ` Boris Ostrovsky
2018-07-30  7:43   ` [Xen-devel] " Xiao Liang
2018-07-29 15:30 ` David Miller
2018-07-30  8:18   ` Xiao Liang [this message]
2018-08-24 11:12     ` [Xen-devel] " Jiri Slaby
2018-08-24 11:26       ` Juergen Gross
2018-08-24 14:26         ` Boris Ostrovsky
2018-09-07 11:06           ` Jiri Slaby
2018-09-07 11:30             ` Juergen Gross
2018-07-30 16:41 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60e93e09-7dc2-d2f6-379d-c1d086aa1f49@redhat.com \
    --to=xiliang@redhat.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=davem@davemloft.net \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).