Re: [PATCH net-next v2 1/4] dpll: zl3073x: remove conditional return with no effect

[Ivan Vecera <ivecera@redhat.com>]

25. července 2026 17:08:49 SELČ, Sang-Heon Jeon <ekffu200098@gmail.com> napsal:
>Both branches of the check return the same value, so the check has
>no effect. Remove it and return the value directly.
>
>This is the result of running the Coccinelle script from
>scripts/coccinelle/misc/cond_return_no_effect.cocci.
>
>Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
>---
> drivers/dpll/zl3073x/dpll.c | 6 +-----
> drivers/dpll/zl3073x/out.c  | 8 ++------
> 2 files changed, 3 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/dpll/zl3073x/dpll.c b/drivers/dpll/zl3073x/dpll.c
>index a2a641b8358f..0488ae6ac486 100644
>--- a/drivers/dpll/zl3073x/dpll.c
>+++ b/drivers/dpll/zl3073x/dpll.c
>@@ -2272,11 +2272,7 @@ zl3073x_dpll_init_fine_phase_adjust(struct zl3073x_dev *zldev)
> 	if (rc)
> 		return rc;
> 
>-	rc = zl3073x_write_u8(zldev, ZL_REG_SYNTH_PHASE_SHIFT_CTRL, 0x01);
>-	if (rc)
>-		return rc;
>-
>-	return rc;
>+	return zl3073x_write_u8(zldev, ZL_REG_SYNTH_PHASE_SHIFT_CTRL, 0x01);
> }
> 
> /**
>diff --git a/drivers/dpll/zl3073x/out.c b/drivers/dpll/zl3073x/out.c
>index eb5628aebcee..410d15b96d0b 100644
>--- a/drivers/dpll/zl3073x/out.c
>+++ b/drivers/dpll/zl3073x/out.c
>@@ -85,12 +85,8 @@ int zl3073x_out_state_fetch(struct zl3073x_dev *zldev, u8 index)
> 	if (rc)
> 		return rc;
> 
>-	rc = zl3073x_read_u32(zldev, ZL_REG_OUTPUT_PHASE_COMP,
>-			      &out->phase_comp);
>-	if (rc)
>-		return rc;
>-
>-	return rc;
>+	return zl3073x_read_u32(zldev, ZL_REG_OUTPUT_PHASE_COMP,
>+				&out->phase_comp);
> }
> 
> /**

Reviewed-by: Ivan Vecera <ivecera@redhat.com>