From: Edward Cree <ecree@solarflare.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: "John W. Linville" <linville@tuxdriver.com>,
netdev <netdev@vger.kernel.org>,
Ganesh Goudar <ganeshgr@chelsio.com>,
"Jakub Kicinski" <jakub.kicinski@netronome.com>,
Dustin Byford <dustin@cumulusnetworks.com>,
Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Subject: Re: [PATCH ethtool] ethtool: support combinations of FEC modes
Date: Wed, 19 Sep 2018 16:38:27 +0100 [thread overview]
Message-ID: <613d954c-d88c-fa20-f436-75625f11a2ae@solarflare.com> (raw)
In-Reply-To: <20180919144117.GF3876@unicorn.suse.cz>
On 19/09/18 15:41, Michal Kubecek wrote:
> I'm sorry I didn't notice this before the patch was accepted but as it's
> not in a release yet, maybe it's still not too late.
>
> Could I suggest to make the syntax consistent with other options?
I didn't realise ethtool had any patterns to be consistent with ;)
> I mean rather than a comma separated list to use either
>
> ethtool --set-fec <dev> encoding enc1 enc2 ...
but yes this looks fine to me, as long as we're reasonably confident that
we won't want to add new parameters (that might require determining
whether enc2 is an encoding or a parameter name) in the future, because
while the parsing wouldn't be impossible it might get ugly.
I'll rustle up an RFC patch.
-Ed
next prev parent reply other threads:[~2018-09-19 21:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 17:54 [PATCH ethtool] ethtool: support combinations of FEC modes Edward Cree
2018-09-17 19:52 ` John W. Linville
2018-09-19 14:41 ` Michal Kubecek
2018-09-19 15:33 ` Andrew Lunn
2018-09-19 15:49 ` Michal Kubecek
2018-09-19 15:38 ` Edward Cree [this message]
2018-09-19 15:56 ` Michal Kubecek
2018-09-19 16:06 ` [RFC PATCH ethtool] ethtool: better syntax for " Edward Cree
2018-09-20 13:46 ` Michal Kubecek
2018-10-01 18:59 ` John W. Linville
2018-10-04 14:08 ` John W. Linville
2018-10-04 14:43 ` Michal Kubecek
2018-10-04 16:06 ` Edward Cree
2018-10-04 19:41 ` John W. Linville
[not found] ` <811cf92b-51ed-4a8f-4b69-113cdd8473df@mellanox.com>
2018-09-26 8:47 ` [PATCH ethtool] ethtool: support " Ariel Almog
2018-09-28 12:58 ` Edward Cree
2018-09-28 15:39 ` Andrew Lunn
2018-09-28 16:11 ` Edward Cree
2018-09-28 16:45 ` Andrew Lunn
2018-09-28 17:30 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613d954c-d88c-fa20-f436-75625f11a2ae@solarflare.com \
--to=ecree@solarflare.com \
--cc=dirk.vandermerwe@netronome.com \
--cc=dustin@cumulusnetworks.com \
--cc=ganeshgr@chelsio.com \
--cc=jakub.kicinski@netronome.com \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).