From: Wojciech Drewek <wojciech.drewek@intel.com>
To: Paolo Abeni <pabeni@redhat.com>, Suman Ghosh <sumang@marvell.com>,
<sgoutham@marvell.com>, <gakula@marvell.com>,
<sbhatta@marvell.com>, <hkelam@marvell.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lcherian@marvell.com>, <jerinj@marvell.com>, <horms@kernel.org>
Subject: Re: [net-next PATCH v3 2/2] octeontx2-pf: TC flower offload support for mirror
Date: Thu, 23 Nov 2023 11:35:45 +0100 [thread overview]
Message-ID: <613da551-9983-4f98-b8c7-57bc16d68665@intel.com> (raw)
In-Reply-To: <92d95955f66098ce725729243251beacc2823a81.camel@redhat.com>
On 23.11.2023 11:21, Paolo Abeni wrote:
> On Tue, 2023-11-21 at 15:48 +0100, Wojciech Drewek wrote:
>>
>> On 21.11.2023 10:43, Suman Ghosh wrote:
>>> This patch extends TC flower offload support for mirroring
>>> ingress/egress traffic to a different PF/VF. Below is an example
>>> command,
>>>
>>> 'tc filter add dev eth1 ingress protocol ip flower src_ip <ip-addr>
>>> skip_sw action mirred ingress mirror dev eth2'
>>>
>>> Signed-off-by: Suman Ghosh <sumang@marvell.com>
>>
>> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
>
> Thank you for your review!
>
> Please, additionally try to trim away the irrelevant part of the patch
> when replying (in this case almost everything). That helps a lot
> following the discussion, especially on long patches, thanks!
Sure thing.
>
> @Suman: please retain Wojciech's tag on next revision of this series.
>
> Cheers,
>
> Paolo
>
prev parent reply other threads:[~2023-11-23 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 9:43 [net-next PATCH v3 0/2] octeontx2: Multicast/mirror offload changes Suman Ghosh
2023-11-21 9:43 ` [net-next PATCH v3 1/2] octeontx2-af: Add new mbox to support multicast/mirror offload Suman Ghosh
2023-11-23 10:17 ` Paolo Abeni
2023-11-26 16:04 ` [EXT] " Suman Ghosh
2023-11-21 9:43 ` [net-next PATCH v3 2/2] octeontx2-pf: TC flower offload support for mirror Suman Ghosh
2023-11-21 10:23 ` Wojciech Drewek
2023-11-21 14:48 ` Wojciech Drewek
2023-11-23 10:21 ` Paolo Abeni
2023-11-23 10:35 ` Wojciech Drewek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613da551-9983-4f98-b8c7-57bc16d68665@intel.com \
--to=wojciech.drewek@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).