From: "Christoph Müllner" <christoph.muellner@theobroma-systems.com>
To: linux-kernel@vger.kernel.org
Cc: "Grant Likely" <grant.likely@linaro.org>,
"Rob Herring" <rob.herring@calxeda.com>,
"David S. Miller" <davem@davemloft.net>,
"Fabio Estevam" <fabio.estevam@freescale.com>,
netdev@vger.kernel.org
Subject: [PATCH] net: fec: Fix multicast list setup in fec_restart().
Date: Fri, 21 Jun 2013 18:40:55 +0200 (CEST) [thread overview]
Message-ID: <61455.62.178.124.14.1371832855.squirrel@mail.theobroma-systems.com> (raw)
Setup the multicast list of the net_device instead of
clearing it blindly. This restores the multicast groups
in case of a link down/up event.
Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
---
drivers/net/ethernet/freescale/fec_main.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index a667015..8e8e743 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -60,6 +60,8 @@
#include "fec.h"
+static void set_multicast_list(struct net_device *ndev);
+
#if defined(CONFIG_ARM)
#define FEC_ALIGNMENT 0xf
#else
@@ -472,8 +474,7 @@ fec_restart(struct net_device *ndev, int duplex)
writel(0xffc00000, fep->hwp + FEC_IEVENT);
/* Reset all multicast. */
- writel(0, fep->hwp + FEC_GRP_HASH_TABLE_HIGH);
- writel(0, fep->hwp + FEC_GRP_HASH_TABLE_LOW);
+ set_multicast_list(ndev);
#ifndef CONFIG_M5272
writel(0, fep->hwp + FEC_HASH_TABLE_HIGH);
writel(0, fep->hwp + FEC_HASH_TABLE_LOW);
--
1.7.4.1
next reply other threads:[~2013-06-21 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 16:40 Christoph Müllner [this message]
2013-06-21 17:15 ` [PATCH] net: fec: Fix multicast list setup in fec_restart() Fabio Estevam
2013-06-27 17:14 ` Christoph Müllner
2013-06-27 17:21 ` Fabio Estevam
2013-06-21 17:25 ` Joe Perches
2013-06-27 19:18 ` [PATCH v2] " Christoph Muellner
2013-07-01 20:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61455.62.178.124.14.1371832855.squirrel@mail.theobroma-systems.com \
--to=christoph.muellner@theobroma-systems.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).