From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCH net 1/2] geneve, vxlan: Don't check skb_dst() twice
Date: Mon, 15 Oct 2018 12:19:41 +0200
Message-ID: <61596775-4b5f-884a-7a0d-d8c134bb7e8a@6wind.com>
References: <cover.1539381018.git.sbrivio@redhat.com>
 <f58a94b95460594c31348cc517f3917bbb9cc51e.1539381018.git.sbrivio@redhat.com>
Reply-To: nicolas.dichtel@6wind.com
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Xin Long <lucien.xin@gmail.com>,
        Sabrina Dubroca <sd@queasysnail.net>, netdev@vger.kernel.org
To: Stefano Brivio <sbrivio@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f47.google.com ([209.85.221.47]:45649 "EHLO
        mail-wr1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726273AbeJOSEW (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 15 Oct 2018 14:04:22 -0400
Received: by mail-wr1-f47.google.com with SMTP id q5-v6so20629732wrw.12
        for <netdev@vger.kernel.org>; Mon, 15 Oct 2018 03:19:44 -0700 (PDT)
In-Reply-To: <f58a94b95460594c31348cc517f3917bbb9cc51e.1539381018.git.sbrivio@redhat.com>
Content-Language: fr
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Le 12/10/2018 à 23:53, Stefano Brivio a écrit :
> Commit f15ca723c1eb ("net: don't call update_pmtu unconditionally") avoids
> that we try updating PMTU for a non-existent destination, but didn't clean
> up cases where the check was already explicit. Drop those redundant checks.
Yes, I leave them to avoid calculating the new mtu value when not needed. We are
in the xmit path.
As skb_dst_update_pmtu() is inlined, we probably don't care, but gcc could still
decide to not inline it.


Regards,
Nicolas