Re: [PATCH v12 13/23] cxl: define a driver interface for DPA allocation

[Alejandro Lucero Palau <alucerop@amd.com>]

On 4/11/25 23:41, Dave Jiang wrote:
>
> On 3/31/25 7:45 AM, alejandro.lucero-palau@amd.com wrote:


snip


>> + * cxl_request_dpa - search and reserve DPA given input constraints
>> + * @cxlmd: memdev with an endpoint port with available decoders
>> + * @is_ram: DPA operation mode (ram vs pmem)
>> + * @alloc: dpa size required
>> + *
>> + * Given that a region needs to allocate from limited HPA capacity it
>> + * may be the case that a device has more mappable DPA capacity than
>> + * available HPA. The expectation is that @alloc is a driver known
>> + * value based on the device capacity but it could not be available
>> + * due to HPA constraints.
>> + *
>> + * Returns a pinned cxl_decoder with at least @alloc bytes of capacity
>> + * reserved, or an error pointer. The caller is also expected to own the
>> + * lifetime of the memdev registration associated with the endpoint to
>> + * pin the decoder registered as well.
>> + */
>> +struct cxl_endpoint_decoder *cxl_request_dpa(struct cxl_memdev *cxlmd,
>> +					     bool is_ram,
> Why not just pass in 'enum cxl_partition_mode' directly?
>
> DJ
>

This predates that definition and you are right for pointing this out.

I will do so.

Thanks!