From: Shannon Nelson <shannon.nelson@amd.com>
To: Emil Tantilov <emil.s.tantilov@intel.com>,
intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, joshua.a.hay@intel.com,
sridhar.samudrala@intel.com, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, willemb@google.com, decot@google.com,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, alan.brady@intel.com,
madhu.chittim@intel.com, phani.r.burra@intel.com,
shailendra.bhatnagar@intel.com, pavan.kumar.linga@intel.com,
simon.horman@corigine.com, leon@kernel.org
Subject: Re: [net-next v3 02/15] idpf: add module register and probe functionality
Date: Thu, 27 Apr 2023 16:24:23 -0700 [thread overview]
Message-ID: <616c557a-16d3-7be3-b0c8-5fa07cbf293e@amd.com> (raw)
In-Reply-To: <20230427020917.12029-3-emil.s.tantilov@intel.com>
On 4/26/23 7:09 PM, Emil Tantilov wrote:
>
> From: Phani Burra <phani.r.burra@intel.com>
>
[...]
> +static int idpf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> +{
> + struct device *dev = &pdev->dev;
> + struct idpf_adapter *adapter;
> + int err;
> +
> + adapter = kzalloc(sizeof(*adapter), GFP_KERNEL);
> + if (!adapter)
> + return -ENOMEM;
> + adapter->pdev = pdev;
The custom more recently has been to allocate the devlink struct early
on and build the device struct from that allocation. You likely will
want to follow along and play in the devlink world.
sln
next prev parent reply other threads:[~2023-04-27 23:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 2:09 [net-next v3 00/15] Introduce Intel IDPF driver Emil Tantilov
2023-04-27 2:09 ` [net-next v3 01/15] virtchnl: add virtchnl version 2 ops Emil Tantilov
2023-04-27 22:04 ` Shannon Nelson
2023-04-28 23:10 ` Tantilov, Emil S
2023-04-27 2:09 ` [net-next v3 02/15] idpf: add module register and probe functionality Emil Tantilov
2023-04-27 23:24 ` Shannon Nelson [this message]
2023-04-28 23:05 ` Tantilov, Emil S
2023-04-27 2:09 ` [net-next v3 03/15] idpf: add controlq init and reset checks Emil Tantilov
2023-04-28 17:16 ` Shannon Nelson
2023-04-28 22:38 ` Tantilov, Emil S
2023-04-27 2:09 ` [net-next v3 04/15] idpf: add core init and interrupt request Emil Tantilov
2023-04-28 19:50 ` Shannon Nelson
2023-04-28 21:17 ` Tantilov, Emil S
2023-04-27 2:09 ` [net-next v3 05/15] idpf: add create vport and netdev configuration Emil Tantilov
2023-04-27 2:09 ` [net-next v3 06/15] idpf: continue expanding init task Emil Tantilov
2023-04-27 2:09 ` [net-next v3 07/15] idpf: configure resources for TX queues Emil Tantilov
2023-04-27 2:09 ` [net-next v3 08/15] idpf: configure resources for RX queues Emil Tantilov
2023-04-27 2:09 ` [net-next v3 09/15] idpf: initialize interrupts and enable vport Emil Tantilov
2023-04-27 2:09 ` [net-next v3 10/15] idpf: add splitq start_xmit Emil Tantilov
2023-04-27 2:09 ` [net-next v3 11/15] idpf: add TX splitq napi poll support Emil Tantilov
2023-04-27 2:09 ` [net-next v3 12/15] idpf: add RX " Emil Tantilov
2023-04-27 2:09 ` [net-next v3 13/15] idpf: add singleq start_xmit and napi poll Emil Tantilov
2023-04-27 2:09 ` [net-next v3 14/15] idpf: add ethtool callbacks Emil Tantilov
2023-04-27 2:09 ` [net-next v3 15/15] idpf: configure SRIOV and add other ndo_ops Emil Tantilov
2023-04-27 2:46 ` [net-next v3 00/15] Introduce Intel IDPF driver Jakub Kicinski
2023-04-27 2:55 ` Tantilov, Emil S
2023-04-27 3:29 ` Jakub Kicinski
2023-04-27 22:23 ` Jesse Brandeburg
2023-05-03 2:20 ` Jakub Kicinski
2023-05-03 16:24 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616c557a-16d3-7be3-b0c8-5fa07cbf293e@amd.com \
--to=shannon.nelson@amd.com \
--cc=alan.brady@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=phani.r.burra@intel.com \
--cc=shailendra.bhatnagar@intel.com \
--cc=simon.horman@corigine.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).