From: John Fastabend <john.fastabend@gmail.com>
To: Quentin Monnet <quentin@isovalent.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
Quentin Monnet <quentin@isovalent.com>
Subject: RE: [PATCH bpf-next 0/3] fixes for bpftool's Makefile
Date: Mon, 18 Oct 2021 07:05:38 -0700 [thread overview]
Message-ID: <616d7f32e2125_1eb12088b@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20211009210341.6291-1-quentin@isovalent.com>
Quentin Monnet wrote:
> This set contains one fix for bpftool's Makefile, to make sure that the
> headers internal to libbpf are installed properly even if we add more
> headers to the relevant Makefile variable in the future (although we'd like
> to avoid that if possible).
>
> The other patches aim at cleaning up the output from the Makefile, in
> particular when running the command "make" another time after bpftool is
> built.
>
> Quentin Monnet (3):
> bpftool: fix install for libbpf's internal header(s)
> bpftool: do not FORCE-build libbpf
> bpftool: turn check on zlib from a phony target into a conditional
> error
>
> tools/bpf/bpftool/Makefile | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> --
> 2.30.2
>
I'm not a Makefile expert, but from my side these look good. Thanks.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2021-10-18 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 21:03 [PATCH bpf-next 0/3] fixes for bpftool's Makefile Quentin Monnet
2021-10-09 21:03 ` [PATCH bpf-next 1/3] bpftool: fix install for libbpf's internal header(s) Quentin Monnet
2021-10-19 23:44 ` Andrii Nakryiko
2021-10-09 21:03 ` [PATCH bpf-next 2/3] bpftool: do not FORCE-build libbpf Quentin Monnet
2021-10-09 21:03 ` [PATCH bpf-next 3/3] bpftool: turn check on zlib from a phony target into a conditional error Quentin Monnet
2021-10-18 14:05 ` John Fastabend [this message]
2021-10-19 23:44 ` [PATCH bpf-next 0/3] fixes for bpftool's Makefile Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616d7f32e2125_1eb12088b@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox