From: John Fastabend <john.fastabend@gmail.com>
To: Wan Jiabing <wanjiabing@vivo.com>, Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: RE: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers
Date: Mon, 18 Oct 2021 09:06:57 -0700 [thread overview]
Message-ID: <616d9ba173075_1eb12088b@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20211012023231.19911-1-wanjiabing@vivo.com>
Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> than once.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> Changelog:
> v2:
> - Fix the commit description.
> ---
The Subject is a bit unusual. Typically it would be something like,
"[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"
For the actual patch though LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2021-10-18 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 2:32 [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers Wan Jiabing
2021-10-18 16:06 ` John Fastabend [this message]
2021-10-20 17:46 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616d9ba173075_1eb12088b@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kael_w@yeah.net \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=wanjiabing@vivo.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox