From: Saeed Mahameed <saeedm@mellanox.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"xiangxia.m.yue@gmail.com" <xiangxia.m.yue@gmail.com>,
"gerlitz.or@gmail.com" <gerlitz.or@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Hadar Hen Zion <hadarh@mellanox.com>
Subject: Re: [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source mac changed
Date: Tue, 29 Jan 2019 22:20:54 +0000 [thread overview]
Message-ID: <6170db12d80e727169dca2d00a0226b91f8f87f0.camel@mellanox.com> (raw)
In-Reply-To: <1548718086-20924-1-git-send-email-xiangxia.m.yue@gmail.com>
On Mon, 2019-01-28 at 15:28 -0800, xiangxia.m.yue@gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> When we offload tc filters to hardware, hardware flows can
> be updated when mac of encap destination ip is changed.
> But we ignore one case, that the mac of local encap ip can
> be changed too, so we should also update them.
>
> To fix it, add route_dev in mlx5e_encap_entry struct to save
> the local encap netdevice, and when mac changed, kernel will
> flush all the neighbour on the netdevice and send
> NETEVENT_NEIGH_UPDATE
> event. The mlx5 driver will delete the flows and add them when
> neighbour
> available again.
>
> Fixes: 232c001398ae ("net/mlx5e: Add support to neighbour update
> flow")
> Cc: Hadar Hen Zion <hadarh@mellanox.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
>
>
Thank you Tonghao and Or.
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
next prev parent reply other threads:[~2019-01-29 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 23:28 [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source mac changed xiangxia.m.yue
2019-01-28 23:28 ` [PATCH net v5 2/2] net/mlx5e: Don't overwrite pedit action when multiple pedit used xiangxia.m.yue
2019-01-29 20:17 ` Or Gerlitz
2019-01-29 22:21 ` Saeed Mahameed
2019-01-29 20:16 ` [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source mac changed Or Gerlitz
2019-01-29 22:20 ` Saeed Mahameed [this message]
2019-02-05 9:03 ` Or Gerlitz
2019-02-07 1:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6170db12d80e727169dca2d00a0226b91f8f87f0.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=hadarh@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox