From: Florian Fainelli <f.fainelli@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Charles-Antoine Couret <charles-antoine.couret@nexvision.fr>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: marvell: fix Marvell 88E1512 used in SGMII mode
Date: Tue, 10 Jan 2017 15:24:11 -0800 [thread overview]
Message-ID: <61950d83-cbe1-6e1b-4afc-bc471b386ff3@gmail.com> (raw)
In-Reply-To: <E1cR5bt-0000O8-1T@rmk-PC.armlinux.org.uk>
On 01/10/2017 03:13 PM, Russell King wrote:
> When an Marvell 88E1512 PHY is connected to a nic in SGMII mode, the
> fiber page is used for the SGMII host-side connection. The PHY driver
> notices that SUPPORTED_FIBRE is set, so it tries reading the fiber page
> for the link status, and ends up reading the MAC-side status instead of
> the outgoing (copper) link. This leads to incorrect results reported
> via ethtool.
>
> If the PHY is connected via SGMII to the host, ignore the fiber page.
> However, continue to allow the existing power management code to
> suspend and resume the fiber page.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Fixes: 6cfb3bcc0641 ("Marvell phy: check link status in case of fiber
link.")
--
Florian
next prev parent reply other threads:[~2017-01-10 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 23:13 [PATCH] net: phy: marvell: fix Marvell 88E1512 used in SGMII mode Russell King
2017-01-10 23:24 ` Florian Fainelli [this message]
2017-01-11 15:03 ` David Miller
2017-01-11 15:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61950d83-cbe1-6e1b-4afc-bc471b386ff3@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=charles-antoine.couret@nexvision.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).