From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25E0FC433FE for ; Fri, 4 Dec 2020 16:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E99BB22A85 for ; Fri, 4 Dec 2020 16:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729858AbgLDQcr (ORCPT ); Fri, 4 Dec 2020 11:32:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgLDQcq (ORCPT ); Fri, 4 Dec 2020 11:32:46 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FDB4C061A4F for ; Fri, 4 Dec 2020 08:32:06 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id l207so3852841oib.4 for ; Fri, 04 Dec 2020 08:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=6V6ugaSMwHvUugy2/G8rXllUlG+uEehtkhroZYeS8dU=; b=UV+YSeNR4zf5O3ZAVa49X+zOSRnzFs+fDL2Qkgvyda9FUeawKccjtWxlVp0sWqUY9J 7awPuoLQK38Shl1JqcUl3uXual1jw/ub9joDXrfyQWQt2m+qn+k16Q1+XZTAFnTnJHvM L4785sOorSpmd4FVLyMtkTNl98d9vCrqPScvkSev2EKNGlpHQss/8hpsJzmJIqwbcA/b BAS/BEYUERlHjlDWy+OdkIQBnmfrbQdLCIlrwwtochvD4nZb0IHdsJwd2O+tOfVRXUVq YDEYcTM2I7a7tOR+1w5wMNyaEUwJRT3xXuXJhjz0fWj1yGDHkI3kwkr8F3rfB5kVZizT Vkag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6V6ugaSMwHvUugy2/G8rXllUlG+uEehtkhroZYeS8dU=; b=Lj9J6jy1567pkuDcmVImMGMTf2Z7K5uhh85obmRgaPdLwwkVOFUSqgMOaHIVU5lpjc OoyZOK+jFkptxHSkw/x7o7Fl2bx3jcqI6CzcSJeEic+huGgF9DCXqorcBK4QjVZtmWyy 7+/n3Z5vX22ROs2YmbnWaiVUxp3S0rArjYDvtGA8m/6pUvRYgr6bN6vm3E+C5WTvKqXp I3DQhsn0mNspD/P1sm6c9vKGtjPOFJf6EVZOArfPqRh8K4c1ZC4d3GeAjIePc/XROjqU zo2zymUXl/h53qUkcGWuQLxPQFKYN8CAM4csx2JZxdRu/kmnp/L2mSwgb6Rwzo8P5Mhe Rbxw== X-Gm-Message-State: AOAM53068f8pB9i8M2pnDM5DQ4GLTfnTbIZi/TYwzXDIx/5WGAdLHQzY 21PwaSCxMUjKqZRLTUlVWHwtQwoxtcQ= X-Google-Smtp-Source: ABdhPJyQ3R5ZeQPy0k3zJua3LHVsBSfM84h8JT172v4hCsrjsoOY5g+YbPtfpdQZC4VEGlLP8UGv1A== X-Received: by 2002:aca:5114:: with SMTP id f20mr3601909oib.107.1607099526016; Fri, 04 Dec 2020 08:32:06 -0800 (PST) Received: from Davids-MacBook-Pro.local ([8.48.134.51]) by smtp.googlemail.com with ESMTPSA id y18sm729989ooj.20.2020.12.04.08.32.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Dec 2020 08:32:05 -0800 (PST) Subject: Re: [PATCH net] vrf: packets with lladdr src needs dst at input with orig_iif when needs strict To: Stephen Suryaputra , netdev@vger.kernel.org References: <20201204030604.18828-1-ssuryaextr@gmail.com> From: David Ahern Message-ID: <6199335a-c50f-6f04-48e2-e71129372a35@gmail.com> Date: Fri, 4 Dec 2020 09:32:04 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201204030604.18828-1-ssuryaextr@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/3/20 8:06 PM, Stephen Suryaputra wrote: > Depending on the order of the routes to fe80::/64 are installed on the > VRF table, the NS for the source link-local address of the originator > might be sent to the wrong interface. > > This patch ensures that packets with link-local addr source is doing a > lookup with the orig_iif when the destination addr indicates that it > is strict. > > Add the reproducer as a use case in self test script fcnal-test.sh. > > Signed-off-by: Stephen Suryaputra > --- > drivers/net/vrf.c | 10 ++- > tools/testing/selftests/net/fcnal-test.sh | 95 +++++++++++++++++++++++ > 2 files changed, 103 insertions(+), 2 deletions(-) > Reviewed-by: David Ahern