From: Daniel Borkmann <daniel@iogearbox.net>
To: Arnd Bergmann <arnd@arndb.de>, Alexei Starovoitov <ast@kernel.org>
Cc: Yonghong Song <yhs@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Song Liu <songliubraving@fb.com>, Martin KaFai Lau <kafai@fb.com>,
Chenbo Feng <fengc@google.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH, net-next 2/2] bpf: avoid -Wmaybe-uninitialized warning
Date: Mon, 28 May 2018 00:37:03 +0200 [thread overview]
Message-ID: <61a96e95-a256-ef40-c25d-e7dbf4c51b02@iogearbox.net> (raw)
In-Reply-To: <20180525213331.2115471-2-arnd@arndb.de>
On 05/25/2018 11:33 PM, Arnd Bergmann wrote:
> The stack_map_get_build_id_offset() function is too long for gcc to track
> whether 'work' may or may not be initialized at the end of it, leading
> to a false-positive warning:
>
> kernel/bpf/stackmap.c: In function 'stack_map_get_build_id_offset':
> kernel/bpf/stackmap.c:334:13: error: 'work' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This removes the 'in_nmi_ctx' flag and uses the state of that variable
> itself to see if it got initialized.
>
> Fixes: bae77c5eb5b2 ("bpf: enable stackmap with build_id in nmi context")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to bpf-next, thanks Arnd!
next prev parent reply other threads:[~2018-05-27 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 21:33 [PATCH, net-next 1/2] bpf: btf: avoid -Wreturn-type warning Arnd Bergmann
2018-05-25 21:33 ` [PATCH, net-next 2/2] bpf: avoid -Wmaybe-uninitialized warning Arnd Bergmann
2018-05-25 21:54 ` Song Liu
2018-05-27 22:37 ` Daniel Borkmann [this message]
2018-05-25 21:53 ` [PATCH, net-next 1/2] bpf: btf: avoid -Wreturn-type warning Song Liu
2018-05-27 22:36 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61a96e95-a256-ef40-c25d-e7dbf4c51b02@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=fengc@google.com \
--cc=jakub.kicinski@netronome.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox