From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64983502A3; Mon, 11 May 2026 19:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778527926; cv=none; b=CP74JXN0ExFYPlLQVv1rIhoI4Kiczg7leU1KtJCC4Ze1kU8fOy1ofoVPXfWGlMjQ0b3FASj0SRkn6ry/1Yt29opni9iM/tfI6KUmeHDyOblUCZaa2xf/AgqwVtHiAMihnYC9Xh9wVR5z6buL4RJuu+zRxj1Jp3tOd1MDSVJYub4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778527926; c=relaxed/simple; bh=OTKeFH7ekblf1QWP5qzcSgiHfKYLciXijKAGIuPSywI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S3docpcQZwDOAWMJKo4neZmUYNEiPmvdz+SaHu9Dc5HDJ+1EoyTNe9pc2iATyRtjiYuk6i5Qu9UW11NEZ9AJUH6cUSMmxSk4PUt+yhIniDEeeAXbK27WaelZWTsRTJfJGLSQlHHnJKdw+PssoefN/YZKaHMQwMcDKvueMxJNhME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=XZjemexM; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XZjemexM" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vMJO8J1w/0efKlrnhHtrOQqrjChnsd5YbtBgoDiehOk=; b=XZjemexM1MVZWWV6TEzhpqKH4D M5lj4mtTe1R0u+vMLY6znPRpB2EwGxT+8nRq9+DBTjFGqMxeIDqb7MMMoJGtdOTktAgPWJw9DinZp keF906hIwpAFudqh6kuqA4ZHTVgQtW9vhmVMtzecX+2f4wm0eHL00qTXgJ8E931u3Q0A=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wMWM5-002QhY-Tc; Mon, 11 May 2026 21:31:53 +0200 Date: Mon, 11 May 2026 21:31:53 +0200 From: Andrew Lunn To: Selvamani Rajagopal Cc: Piergiorgio Beruto , "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v2 4/9] net: phy: ncn26000: Support for internal phy for S2500 Message-ID: <61b47eb5-4d3f-4d0a-9593-24f22781808f@lunn.ch> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > + /* NCN26000 PHY didn't have the default value */ > + if (pdrv->phy_id == PHY_ID_NCN26000) > + PHY_ID_MATCH_MODEL(PHY_ID_S2500), Since you are using PHY_ID_MATCH_MODEL(), you should use phy_id_compare_model(). Andrew