From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 1/2] Documentation: devicetree: clarify usage of the RGMII phy-modes Date: Sat, 26 Nov 2016 21:53:47 -0800 Message-ID: <61b8fa1b-e947-16ca-fb97-02a1125042aa@gmail.com> References: <20161125131201.19994-1-martin.blumenstingl@googlemail.com> <20161125131201.19994-2-martin.blumenstingl@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org To: Martin Blumenstingl , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <20161125131201.19994-2-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 11/25/2016 05:12 AM, Martin Blumenstingl wrote: > RGMII requires special RX and/or TX delays depending on the actual > hardware circuit/wiring. These delays can be added by the MAC, the PHY > or the designer of the circuit (the latter means that no delay has to > be added by PHY or MAC). > There are 4 RGMII phy-modes used describe where a delay should be > applied: > - rgmii: the RX and TX delays are either added by the MAC (where the > exact delay is typically configurable, and can be turned off when no > extra delay is needed) or not needed at all (because the hardware > wiring adds the delay already). The PHY should neither add the RX nor > TX delay in this case. > - rgmii-rxid: configures the PHY to enable the RX delay. The MAC should > not add the RX delay in this case. > - rgmii-txid: configures the PHY to enable the TX delay. The MAC should > not add the TX delay in this case. > - rgmii-id: combines rgmii-rxid and rgmii-txid and thus configures the > PHY to enable the RX and TX delays. The MAC should neither add the RX > nor TX delay in this case. > > Document these cases in the ethernet.txt documentation to make it clear > when to use each mode. > If applied incorrectly one might end up with MAC and PHY both enabling > for example the TX delay, which breaks ethernet TX traffic on 1000Mbit/s > links. > > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html