From: kovalev@altlinux.org
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, jiri@resnulli.us,
jacob.e.keller@intel.com, johannes@sipsolutions.net,
idosch@nvidia.com, horms@kernel.org, david.lebrun@uclouvain.be
Subject: Re: [PATCH net ver.2] genetlink: fix possible use-after-free and null-ptr-deref in genl_dumpit()
Date: Tue, 20 Feb 2024 14:03:55 +0300 [thread overview]
Message-ID: <61ba58b4-abc7-2b87-c25f-91ada2f28cfc@basealt.ru> (raw)
In-Reply-To: <ZdSAndRQxKGkV/EO@calendula>
Hi Pablo,
20.02.2024 13:36, Pablo Neira Ayuso wrote:
> On Tue, Feb 20, 2024 at 01:25:12PM +0300, kovalev@altlinux.org wrote:
>> From: Vasiliy Kovalev <kovalev@altlinux.org>
>>
>> The pernet operations structure for the subsystem must be registered
>> before registering the generic netlink family.
> IIRC, you pointed to a syzbot report on genetlink similar to gtp.
Yes, I was referring to the link
https://lore.kernel.org/all/0000000000007549a6060f99544d@google.com/T/ ,
>
> Maybe add that tag here and get the robot to test this fix?
but since the syzbot does not have a reproducer, I cannot say for sure
that this is exactly the problem that this patch fixes, since syzbot
refers to the tipc_udp_nl_dump_remoteip function and suddenly there is
another problem...
>
> I'd suggest to describe the scenario, which is: There is a race that
> allows netlink dump and walking on pernet data while such pernet data
> is not yet set up.
>
> Thanks.
--
Regards,
Vasiliy Kovalev
next prev parent reply other threads:[~2024-02-20 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 10:25 [PATCH net ver.2] genetlink: fix possible use-after-free and null-ptr-deref in genl_dumpit() kovalev
2024-02-20 10:36 ` Pablo Neira Ayuso
2024-02-20 11:03 ` kovalev [this message]
2024-02-22 1:23 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61ba58b4-abc7-2b87-c25f-91ada2f28cfc@basealt.ru \
--to=kovalev@altlinux.org \
--cc=davem@davemloft.net \
--cc=david.lebrun@uclouvain.be \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).