From: Wang Liang <wangliang74@huawei.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yuehaibing@huawei.com>,
<zhangchangzhong@huawei.com>
Subject: Re: [PATCH net-next] selftests: net: check jq command is supported
Date: Sat, 11 Oct 2025 11:26:08 +0800 [thread overview]
Message-ID: <61c106d9-6ea9-4ed4-ae01-267e6691e80b@huawei.com> (raw)
In-Reply-To: <bd3149e8-e213-48b0-8f8a-0888d1837b84@redhat.com>
在 2025/10/10 22:56, Paolo Abeni 写道:
> On 10/10/25 5:30 AM, Wang Liang wrote:
>> The jq command is used in vlan_bridge_binding.sh, if it is not supported,
>> the test will spam the following log.
>>
>> # ./vlan_bridge_binding.sh: line 51: jq: command not found
>> # ./vlan_bridge_binding.sh: line 51: jq: command not found
>> # ./vlan_bridge_binding.sh: line 51: jq: command not found
>> # ./vlan_bridge_binding.sh: line 51: jq: command not found
>> # ./vlan_bridge_binding.sh: line 51: jq: command not found
>> # TEST: Test bridge_binding on->off when lower down [FAIL]
>> # Got operstate of , expected 0
>>
>> The rtnetlink.sh has the same problem. It makes sense to check if jq is
>> installed before running these tests. After this patch, the
>> vlan_bridge_binding.sh skipped if jq is not supported:
>>
>> # timeout set to 3600
>> # selftests: net: vlan_bridge_binding.sh
>> # TEST: jq not installed [SKIP]
>>
>> Signed-off-by: Wang Liang <wangliang74@huawei.com>
> This looks more a fix than net-next material (and net-next is currently
> closed for the merge window).
>
> Please re-post for net including suitable fixes tag(s). You can retain
> Hangbin's ack.
>
> Thanks,
>
> Paolo
Thanks for your reminder!
I missed the ANN e-mail when I was in Chinese National Day vacation. I will
repost this patch for net later.
------
Best regards
Wang Liang
>
prev parent reply other threads:[~2025-10-11 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 3:30 [PATCH net-next] selftests: net: check jq command is supported Wang Liang
2025-10-10 10:02 ` Hangbin Liu
2025-10-10 14:56 ` Paolo Abeni
2025-10-11 3:26 ` Wang Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c106d9-6ea9-4ed4-ae01-267e6691e80b@huawei.com \
--to=wangliang74@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox